Skip to content

Conversation

akhila-guruju
Copy link
Contributor

@akhila-guruju akhila-guruju commented Jul 17, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

patch nodejs for CVE-2025-23167
Astrolabe Patch Reference: nodejs/node#48981
Upstream patch reference: nodejs/node@a7b8e85
Patch Modified: Yes

  • no need to patch for doc/contributing/maintaining/maintaining-dependencies.md as no version information is given in code for other deps also.
  • Since azl is using llhttp v8.1.2 and the upstream patch is for an earlier version, v8.1.1, some changes are already included in azl.
Change Log
  • new file: SPECS/nodejs/CVE-2025-23167.patch
  • modified: SPECS/nodejs/nodejs.spec
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jul 17, 2025
@akhila-guruju akhila-guruju changed the title checking build for nodejs with patch [Medium] Patch nodejs for CVE-2025-23167 Jul 18, 2025
@akhila-guruju akhila-guruju changed the title [Medium] Patch nodejs for CVE-2025-23167 checking build for nodejs after applying patch Jul 18, 2025
@akhila-guruju akhila-guruju changed the title checking build for nodejs after applying patch [Medium] Patch nodejs for CVE-2025-23167 Jul 24, 2025
@akhila-guruju akhila-guruju marked this pull request as ready for review July 24, 2025 07:17
@akhila-guruju akhila-guruju requested a review from a team as a code owner July 24, 2025 07:17
@Malateshk007 Malateshk007 requested a review from kgodara912 July 28, 2025 05:48
Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the number of changes in patch, we should proceed with nodejs 20.19.2 upgrade. From the response of copilot, 20.19.2 version should be compatible with 20.14
"""
Yes, Node.js 20.19.x is backward compatible with 20.14.x because both are part of the same LTS major version (20.x). Node.js follows semantic versioning, so:

Minor releases (20.14 → 20.19) only add features, improvements, and security fixes.
They do not introduce breaking changes to existing APIs within the same major version.
Your existing code that runs on 20.14 should work on 20.19 without modification.

The only differences you might notice:

Security patches (like CVE-2025-23167 fix).
Performance improvements and bug fixes.
Occasionally, new warnings for deprecated features (but no removals).

✅ Safe to upgrade: For your case, moving from 20.14.0 → 20.19.2 is considered a drop-in replacement.
"""
Given that we are going to support nodejs for Azure Linux 3.0 for longer durations, the patching will become difficult over time and also nodejs 20.14 is part of same LTS as 20.19 and nodejs 20.x series is maintained series from upstream community. This version upgrade will give us flexibility for future vulnerability fixes with further maintained/stable version of nodejs from package maintainer themselves.

@Malateshk007 Malateshk007 requested a review from Sumynwa August 22, 2025 06:46
@Malateshk007
Copy link

@Sumynwa, gentle reminder for review and approval!

1 similar comment
@Malateshk007
Copy link

@Sumynwa, gentle reminder for review and approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants