Impoving container initialize logic #5280
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MantavyaDh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR aims to improve the container initialize logic, before retrying to start a container we have added a check to see if its already running as we've had cases wherein the container starts but not reported by docker daemon.
Description
Added logic to check if container already running before retrying.
Risk Assessment (Low / Medium / High)
Low, only introduces a check before retrying
Unit Tests Added or Updated (Yes / No)
Yes, Unit tests added
Additional Testing Performed
Tested in personal org
Change Behind Feature Flag (Yes / No)
TBD
Documentation Changes Required (Yes/No)
No
Logging Added/Updated (Yes/No)
Logs added.
Rollback Scenario and Process (Yes/No)
TBD
Dependency Impact Assessed and Regression Tested (Yes/No)