-
Notifications
You must be signed in to change notification settings - Fork 895
Deactivate Base64 Encoded Vso Commands AB#2008236 #5158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5d882e
to
a491ccf
Compare
/azp run |
marekzmyslowski
previously approved these changes
Mar 26, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sanjuyadav24
previously approved these changes
Apr 3, 2025
AdityaMankal-MS
suggested changes
Apr 4, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
AdityaMankal-MS
suggested changes
Apr 14, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
83442be
to
21631ce
Compare
tarunramsinghani
approved these changes
Apr 15, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
AdityaMankal-MS
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
tarunramsinghani
approved these changes
May 2, 2025
Closed
4 tasks
dassayantan24
added a commit
that referenced
this pull request
Jun 3, 2025
This reverts commit bc979be.
dassayantan24
added a commit
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Some pipeline variables may contain encoded vso commands which will be executed if it will be specified in script as output
We want to prevent this behavior by deactivating commands in these variables
Description:
Added DeactivateBase64EncodedVsoCommands util which disables all vso commands in line
Risk Assesment(Low/Medium/High): low
Added unit tests: (Y/N) Y
Additional Tests Performed: N