Skip to content

Deactivate Base64 Encoded Vso Commands AB#2008236 #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 2, 2025

Conversation

praval-microsoft
Copy link
Contributor

@praval-microsoft praval-microsoft commented Mar 26, 2025

Issue: Some pipeline variables may contain encoded vso commands which will be executed if it will be specified in script as output
We want to prevent this behavior by deactivating commands in these variables

Description:
Added DeactivateBase64EncodedVsoCommands util which disables all vso commands in line

Risk Assesment(Low/Medium/High): low

Added unit tests: (Y/N) Y

Additional Tests Performed: N

@praval-microsoft
Copy link
Contributor Author

/azp run

@praval-microsoft praval-microsoft added the misc Miscellaneous Changes label Apr 3, 2025
@praval-microsoft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praval-microsoft praval-microsoft changed the title Deactivate Base64 Encoded Vso Commands Deactivate Base64 Encoded Vso Commands AB#2008236 Apr 3, 2025
@praval-microsoft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praval-microsoft praval-microsoft marked this pull request as ready for review April 3, 2025 06:52
@praval-microsoft praval-microsoft requested review from a team as code owners April 3, 2025 06:52
sanjuyadav24
sanjuyadav24 previously approved these changes Apr 3, 2025
@praval-microsoft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praval-microsoft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praval-microsoft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@praval-microsoft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@AdityaMankal-MS AdityaMankal-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

@rajmishra1997
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarunramsinghani tarunramsinghani merged commit bc979be into master May 2, 2025
19 of 20 checks passed
@tarunramsinghani tarunramsinghani deleted the VsoCommandDeactivate branch May 2, 2025 10:15
dassayantan24 added a commit that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc Miscellaneous Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants