This repository was archived by the owner on Feb 22, 2025. It is now read-only.
Delete ignored files #337
Merged
Delete ignored files #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForNeVeR
force-pushed
the
bugfix/330.delete-ignored-files
branch
19 times, most recently
from
85a6a0c to
16021f9
Compare
…330) Reactive client will now behave the same as the classic one.
This helps us to make decisions based on the real situation client has encountered: if the paths in question are marked as "not found", it may mean that the paths are ignored and we have to delete them via external means.
Forbid telemetry, forbid keychain access.
ForNeVeR
force-pushed
the
bugfix/330.delete-ignored-files
branch
from
16021f9 to
80e48ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #330.
This PR modifies the behavior of delete operation for both classic and reactive clients, and makes them to behave the same: they won't throw any exceptions on delete, but will return three collections:
With these changes, it's now possible to distinguish the situations when there was a delete error, and the situations when the client wasn't able to found a TFVC item we're about to delete.
In the latter case, it means the item was probably explicitly ignored by the user, so we could let IDEA to proceed with the item delete operation, and shouldn't handle this item via the TFVC client.
Another big change included into this PR is the reactive client test addition: from now on, the reactive client backend will be tested by our test suite, too.
Also, to enable the tests, I had to fix a small bug in our fork of TFS SDK, and update its version to 14.135.1.