-
Notifications
You must be signed in to change notification settings - Fork 950
.NET Workflows - Update Declarative Integration Tests for File Cases #2733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Workflows - Update Declarative Integration Tests for File Cases #2733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refines integration tests for declarative workflows by improving file input handling, separating agent definitions, and creating a dedicated vision agent for testing image and document processing capabilities.
Key Changes
- Created dedicated
VisionAgentProviderfor vision-based testing scenarios - Refactored tests to support both image and PDF file types with parameterized test cases
- Enhanced test validation with improved assertions and output logging
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| MediaInput.yaml | Simplified workflow configuration by removing inline instructions and referencing dedicated VisionAgent |
| MediaInputTest.cs | Refactored tests from [Fact] to [Theory] to support multiple file types (images and PDFs) with parameterized data |
| VisionAgentProvider.cs | Added new agent provider specifically for vision/document analysis with appropriate instructions |
| TestAgentProvider.cs | Updated agent description to be more generic ("Basic agent") to reflect its general-purpose nature |
| AgentProvider.cs | Extended factory to support creation of VisionAgent through new Names.Vision constant |
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs
Outdated
Show resolved
Hide resolved
...sts/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/VisionAgentProvider.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs
Outdated
Show resolved
Hide resolved
…tionTests/Agents/VisionAgentProvider.cs Co-authored-by: Copilot <[email protected]>
…ps://github.com/microsoft/agent-framework into crickman/workflow-integration-test-improvements
Motivation and Context
Refine test-cases around file input for declarative workfows.
Description
Contribution Checklist