Skip to content

Conversation

@crickman
Copy link
Contributor

@crickman crickman commented Dec 9, 2025

Motivation and Context

Refine test-cases around file input for declarative workfows.

Description

  • Improve test validation
  • Separate agent definitions
  • Create appropriate agent for vision tests

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@crickman crickman self-assigned this Dec 9, 2025
@crickman crickman added the workflows Related to Workflows in agent-framework label Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 20:21
@crickman crickman enabled auto-merge December 9, 2025 20:30
@crickman crickman moved this to In Review in Agent Framework Dec 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines integration tests for declarative workflows by improving file input handling, separating agent definitions, and creating a dedicated vision agent for testing image and document processing capabilities.

Key Changes

  • Created dedicated VisionAgentProvider for vision-based testing scenarios
  • Refactored tests to support both image and PDF file types with parameterized test cases
  • Enhanced test validation with improved assertions and output logging

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
MediaInput.yaml Simplified workflow configuration by removing inline instructions and referencing dedicated VisionAgent
MediaInputTest.cs Refactored tests from [Fact] to [Theory] to support multiple file types (images and PDFs) with parameterized data
VisionAgentProvider.cs Added new agent provider specifically for vision/document analysis with appropriate instructions
TestAgentProvider.cs Updated agent description to be more generic ("Basic agent") to reflect its general-purpose nature
AgentProvider.cs Extended factory to support creation of VisionAgent through new Names.Vision constant

…tionTests/Agents/VisionAgentProvider.cs

Co-authored-by: Copilot <[email protected]>
@crickman crickman added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 0965a83 Dec 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET workflows Related to Workflows in agent-framework

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants