-
Notifications
You must be signed in to change notification settings - Fork 950
.NET: Remove unnecessary PackageReferences after .NET 10 update #2394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR cleans up unnecessary PackageReferences following the .NET 10 update. The changes remove packages that are now included in the .NET 10.0 framework, reducing dependencies while maintaining backward compatibility with earlier framework versions.
Key changes:
- Removed
System.Net.ServerSentEvents,Microsoft.Bcl.AsyncInterfaces, andSystem.Text.Jsonpackage references that are now part of .NET 10.0 - Removed conditional ItemGroups that contained only these now-unnecessary packages
- Retained
System.Linq.AsyncEnumerablein conditional blocks for pre-.NET 10.0 framework support
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.Agents.AI.Hosting.AzureFunctions.IntegrationTests.csproj | Removed version override for System.Net.ServerSentEvents |
| Microsoft.Agents.AI.Hosting.AGUI.AspNetCore.UnitTests.csproj | Removed Microsoft.Bcl.AsyncInterfaces and System.Text.Json from conditional package references |
| Microsoft.Agents.AI.Hosting.AGUI.AspNetCore.IntegrationTests.csproj | Removed conditional ItemGroup containing System.Net.ServerSentEvents |
| Microsoft.Agents.AI.Abstractions.UnitTests.csproj | Removed Microsoft.Bcl.AsyncInterfaces and System.Text.Json from conditional package references |
| Microsoft.Agents.AI.AGUI.UnitTests.csproj | Removed unconditional package references for System.Net.ServerSentEvents, Microsoft.Bcl.AsyncInterfaces, and System.Text.Json |
| Microsoft.Agents.AI.A2A.UnitTests.csproj | Removed unconditional ItemGroup containing System.Net.ServerSentEvents and Microsoft.Bcl.AsyncInterfaces |
| AgentConformance.IntegrationTests.csproj | Removed Microsoft.Bcl.AsyncInterfaces and System.Text.Json from conditional package references |
| Microsoft.Agents.AI.Hosting.OpenAI.csproj | Removed System.Net.ServerSentEvents and System.Text.Json from conditional package references |
| Microsoft.Agents.AI.Hosting.AGUI.AspNetCore.csproj | Removed conditional ItemGroup containing System.Net.ServerSentEvents and System.Text.Json |
| Microsoft.Agents.AI.Hosting.A2A.csproj | Removed conditional ItemGroup containing System.Net.ServerSentEvents |
| Microsoft.Agents.AI.Hosting.A2A.AspNetCore.csproj | Removed System.Net.ServerSentEvents and System.Text.Json from conditional package references |
| Microsoft.Agents.AI.AGUI.csproj | Removed unconditional Microsoft.Bcl.AsyncInterfaces package reference |
| Microsoft.Agents.AI.A2A.csproj | Removed unconditional package references for System.Net.ServerSentEvents and Microsoft.Bcl.AsyncInterfaces |
| Agent_MCP_Server_Auth.csproj | Removed conditional ItemGroup containing System.Net.ServerSentEvents |
| Agent_Step10_AsMcpTool.csproj | Removed conditional ItemGroup containing System.Net.ServerSentEvents |
| A2AAgent_AsFunctionTools.csproj | Removed conditional ItemGroup containing System.Net.ServerSentEvents and Microsoft.Bcl.AsyncInterfaces |
| A2AClient.csproj | Removed conditional ItemGroup containing System.Net.ServerSentEvents and Microsoft.Bcl.AsyncInterfaces |
391b64e to
c008063
Compare
No description provided.