Skip to content

Updated DesignTools project's output path #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

brianlagunas
Copy link
Collaborator

Description of Change

Modified the build output path of the DesignTools projects from the old net45 to net462 due to the recent framework upgrades.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@brianlagunas
Copy link
Collaborator Author

I have an overall concern about the current approach for building the design projects.

@mgoertz-msft can you confirm this is the correct way to output these design assemblies? Do we do something in Azure DevOps to correctly package the design assemblies for each TFM?

@mgoertz-msft
Copy link
Member

I guess the validation error may have the answer...

@mgoertz-msft
Copy link
Member

@brianlagunas Found it:

<Target Name="IncludeProjectToProjectAssets">

Perhaps we need to put the TFMs we are targeting in a .props file so we don't have to change them in multiple different places

@brianlagunas
Copy link
Collaborator Author

Yeah, I think this is an area that needs improvement. I'll get this fixed so that what we have builds, then look to improve this process in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants