Skip to content

Conversation

@Arnavion
Copy link
Contributor

@Arnavion Arnavion commented May 7, 2016

  1. Array, TypedArray, Map and Set methods that are specced to return the this-object now return this instead of explicit type.
  2. Added an overload for ES6 String.normalize's that has form parameter as union of the allowed string literals.

tests/cases/compiler/implementArrayInterface started failing until I updated it, since it is now an error to implement array methods with old callback that accepted T[]. Breaking change?

jake runtests passes.


Based on #7664. Since @mhegazy asked for the change to the callbacks to accept this be reverted, and since master split es6.d.ts into multiple files, it was cleaner to just rebase the change onto master than do reverts and merges. To preserve the comments on the diff of that PR I decided to make a new PR.

Note that, as mentioned above, tests/cases/compiler/implementArrayInterface still requires changes to compile (since sort now returns this instead of T[]). I'm not sure I see the value of not taking the callback changes since it's still a breaking change for custom Array<T> implementations.

cc @jods4

@mhegazy
Copy link
Contributor

mhegazy commented May 9, 2016

thanks!

@mhegazy mhegazy merged commit cf4d94b into microsoft:master May 9, 2016
mhegazy added a commit to mhegazy/DefinitelyTyped that referenced this pull request May 24, 2016
With change microsoft/TypeScript#8515, `Uint8Array.fill` method now returns `this`.
Fixing definition of `NodeBuffer` to maintain extends relationship with `Uint8Array`
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants