this-related changes + new String.normalize overload
#8515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thisinstead of explicit type.formparameter as union of the allowed string literals.tests/cases/compiler/implementArrayInterfacestarted failing until I updated it, since it is now an error to implement array methods with old callback that acceptedT[]. Breaking change?jake runtestspasses.Based on #7664. Since @mhegazy asked for the change to the callbacks to accept
thisbe reverted, and since master split es6.d.ts into multiple files, it was cleaner to just rebase the change onto master than do reverts and merges. To preserve the comments on the diff of that PR I decided to make a new PR.Note that, as mentioned above,
tests/cases/compiler/implementArrayInterfacestill requires changes to compile (sincesortnow returnsthisinstead ofT[]). I'm not sure I see the value of not taking the callback changes since it's still a breaking change for customArray<T>implementations.cc @jods4