Propagate errorType in getConditionalType

[ahejlsberg]

Fixes #53783.

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 3ff719b. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 3ff719b. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 3ff719b. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 3ff719b. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 3ff719b. You can monitor the build here.

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53801/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Package install failed"

Otherwise...

Everything looks good!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53801

Metric	main	53801	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	364,557k (± 0.01%)	364,560k (± 0.01%)	~	364,517k	364,592k	p=0.471 n=6
Parse Time	3.55s (± 0.37%)	3.55s (± 0.38%)	~	3.53s	3.56s	p=1.000 n=6
Bind Time	1.18s (± 0.46%)	1.18s (± 0.46%)	~	1.18s	1.19s	p=1.000 n=6
Check Time	9.51s (± 0.42%)	9.50s (± 0.45%)	~	9.42s	9.54s	p=1.000 n=6
Emit Time	7.96s (± 1.35%)	7.94s (± 1.03%)	~	7.87s	8.09s	p=0.629 n=6
Total Time	22.21s (± 0.53%)	22.17s (± 0.40%)	~	22.05s	22.32s	p=0.872 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	192,574k (± 0.03%)	193,137k (± 0.70%)	~	192,551k	195,902k	p=0.470 n=6
Parse Time	1.59s (± 0.32%)	1.59s (± 1.17%)	~	1.56s	1.61s	p=0.351 n=6
Bind Time	0.83s (± 0.66%)	0.82s (± 0.63%)	~	0.82s	0.83s	p=0.640 n=6
Check Time	10.19s (± 0.44%)	10.21s (± 0.36%)	~	10.18s	10.28s	p=0.629 n=6
Emit Time	2.97s (± 0.66%)	2.99s (± 1.15%)	~	2.94s	3.04s	p=0.469 n=6
Total Time	15.59s (± 0.31%)	15.62s (± 0.43%)	~	15.53s	15.72s	p=0.334 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,754k (± 0.01%)	345,754k (± 0.00%)	~	345,734k	345,777k	p=1.000 n=6
Parse Time	2.71s (± 0.30%)	2.72s (± 0.40%)	~	2.71s	2.74s	p=0.383 n=6
Bind Time	1.08s (± 0.75%)	1.09s (± 0.77%)	~	1.07s	1.09s	p=0.718 n=6
Check Time	7.83s (± 0.48%)	7.85s (± 0.24%)	~	7.82s	7.87s	p=0.331 n=6
Emit Time	4.45s (± 0.93%)	4.44s (± 1.05%)	~	4.39s	4.51s	p=0.743 n=6
Total Time	16.07s (± 0.49%)	16.11s (± 0.36%)	~	16.02s	16.19s	p=0.572 n=6
TFS - node (v16.17.1, x64)
Memory used	300,031k (± 0.00%)	300,055k (± 0.01%)	+25k (+ 0.01%)	300,026k	300,075k	p=0.030 n=6
Parse Time	2.15s (± 0.78%)	2.16s (± 0.56%)	~	2.15s	2.18s	p=0.162 n=6
Bind Time	1.23s (± 0.33%)	1.23s (± 0.85%)	~	1.22s	1.25s	p=0.209 n=6
Check Time	7.18s (± 0.26%)	7.19s (± 0.44%)	~	7.14s	7.23s	p=0.372 n=6
Emit Time	4.35s (± 0.84%)	4.37s (± 0.79%)	~	4.33s	4.42s	p=0.335 n=6
Total Time	14.90s (± 0.42%)	14.96s (± 0.39%)	~	14.87s	15.04s	p=0.126 n=6
material-ui - node (v16.17.1, x64)
Memory used	481,160k (± 0.01%)	481,141k (± 0.01%)	~	481,077k	481,272k	p=0.521 n=6
Parse Time	3.24s (± 0.42%)	3.25s (± 0.39%)	~	3.24s	3.27s	p=0.868 n=6
Bind Time	0.94s (± 0.88%)	0.95s (± 0.79%)	~	0.94s	0.96s	p=0.432 n=6
Check Time	17.82s (± 0.65%)	17.80s (± 0.47%)	~	17.71s	17.95s	p=1.000 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.00s (± 0.55%)	22.00s (± 0.37%)	~	21.93s	22.14s	p=0.936 n=6
xstate - node (v16.17.1, x64)
Memory used	559,385k (± 0.03%)	559,377k (± 0.03%)	~	559,254k	559,600k	p=0.810 n=6
Parse Time	3.98s (± 0.27%)	4.00s (± 0.43%)	~	3.98s	4.03s	p=0.052 n=6
Bind Time	1.75s (± 0.30%)	1.75s (± 0.51%)	~	1.74s	1.76s	p=0.541 n=6
Check Time	3.02s (± 0.44%)	3.03s (± 0.65%)	~	3.01s	3.05s	p=0.622 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	8.83s (± 0.19%)	8.88s (± 0.32%)	+0.04s (+ 0.49%)	8.85s	8.92s	p=0.011 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	53801	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53801/merge:

Everything looks good!

[typescript-bot]

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.