Report excess property errors on object literal names #53129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Andarist
commented
Mar 7, 2023
| errorNode = propDeclaration; | ||
|
|
||
| const name = propDeclaration.name!; | ||
| errorNode = name; |
Contributor
Author
There was a problem hiding this comment.
this basically uses the same strategy to overwrite the errorNode as the one used by the JSX-related code path here:
https://github.dev/microsoft/TypeScript/blob/6dbec02a88156121c24a152d1e8e5e82d52fdc1d/src/compiler/checker.ts#L20691
DanielRosenwasser
approved these changes
Mar 7, 2023
jakebailey
approved these changes
Mar 7, 2023
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Love it! Are we missing any more cases? 😄
Contributor
Author
I plan to grep the test cases against all multi-line errors. I think that this should find all candidates for potential improvements - gonna categorize them and rethink if error spans can be improved for any of them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a spiritual follow-up to #52943
the problem was noticed by @jakebailey here
Note that this is how it was already behaving in JSX so it unifies both paths, see the playground here