Check nested weak types in intersections on target side of relation #51140

ahejlsberg · 2022-10-11T01:18:48Z

This PR also moves some intersection property check logic from isRelatedTo to structuredTypeRelatedTo (i.e. from the un-cached to the cached side of relationship checking). This allows us to get rid of a separate cache lookup and two associated IntersectionState flags.

ahejlsberg · 2022-10-11T01:19:28Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2022-10-11T01:19:31Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 72a0f3b. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-11T01:19:31Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 72a0f3b. You can monitor the build here.

typescript-bot · 2022-10-11T01:19:31Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 72a0f3b. You can monitor the build here.

typescript-bot · 2022-10-11T01:19:31Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 72a0f3b. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-11T01:19:32Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 72a0f3b. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-11T01:34:09Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/51140/merge:

Everything looks good!

typescript-bot · 2022-10-11T01:37:25Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51140

_Metric	_main	₅₁₁₄₀	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{352,327k (± 0.02%)}	_{352,403k (± 0.02%)}	_{+75k (+ 0.02%)}	_352,120k	_352,509k
_{Parse Time}	_{1.90s (± 0.77%)}	_{1.91s (± 0.60%)}	_{+0.02s (+ 0.90%)}	_1.90s	_1.95s
_{Bind Time}	_{0.74s (± 0.40%)}	_{0.75s (± 0.66%)}	_{+0.00s (+ 0.54%)}	_0.74s	_0.76s
_{Check Time}	_{5.67s (± 0.55%)}	_{5.69s (± 0.63%)}	_{+0.02s (+ 0.39%)}	_5.63s	_5.77s
_{Emit Time}	_{6.06s (± 0.88%)}	_{6.10s (± 0.59%)}	_{+0.04s (+ 0.71%)}	_6.03s	_6.19s
_{Total Time}	_{14.37s (± 0.60%)}	_{14.46s (± 0.47%)}	_{+0.09s (+ 0.59%)}	_14.33s	_14.65s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{198,639k (± 0.60%)}	_{198,144k (± 0.49%)}	_{-495k (- 0.25%)}	_197,401k	_200,827k
_{Parse Time}	_{0.78s (± 0.79%)}	_{0.79s (± 0.87%)}	_{+0.00s (+ 0.64%)}	_0.77s	_0.80s
_{Bind Time}	_{0.45s (± 0.89%)}	_{0.46s (± 1.04%)}	_{+0.01s (+ 1.33%)}	_0.45s	_0.47s
_{Check Time}	_{6.49s (± 0.66%)}	_{6.52s (± 0.51%)}	_{+0.03s (+ 0.51%)}	_6.47s	_6.62s
_{Emit Time}	_{2.31s (± 1.02%)}	_{2.29s (± 0.68%)}	_{-0.02s (- 0.74%)}	_2.25s	_2.33s
_{Total Time}	_{10.03s (± 0.56%)}	_{10.06s (± 0.36%)}	_{+0.03s (+ 0.27%)}	_10.00s	_10.16s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{331,117k (± 0.01%)}	_{331,138k (± 0.01%)}	_{+20k (+ 0.01%)}	_331,059k	_331,215k
_{Parse Time}	_{1.42s (± 0.71%)}	_{1.43s (± 0.45%)}	_{+0.00s (+ 0.21%)}	_1.41s	_1.44s
_{Bind Time}	_{0.69s (± 1.09%)}	_{0.70s (± 0.98%)}	_{+0.00s (+ 0.29%)}	_0.68s	_0.71s
_{Check Time}	_{5.47s (± 0.50%)}	_{5.48s (± 0.46%)}	_{+0.01s (+ 0.16%)}	_5.43s	_5.54s
_{Emit Time}	_{3.25s (± 0.58%)}	_{3.26s (± 0.52%)}	_{+0.01s (+ 0.40%)}	_3.24s	_3.31s
_{Total Time}	_{10.84s (± 0.39%)}	_{10.87s (± 0.37%)}	_{+0.03s (+ 0.28%)}	_10.80s	_10.96s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{294,083k (± 0.01%)}	_{294,042k (± 0.02%)}	_{-41k (- 0.01%)}	_293,880k	_294,132k
_{Parse Time}	_{1.21s (± 1.34%)}	_{1.24s (± 1.23%)}	_{+0.02s (+ 1.98%)}	_1.21s	_1.29s
_{Bind Time}	_{0.64s (± 0.97%)}	_{0.64s (± 0.62%)}	_{+0.00s (+ 0.31%)}	_0.63s	_0.65s
_{Check Time}	_{5.09s (± 0.39%)}	_{5.13s (± 0.41%)}	_{+0.04s (+ 0.77%)}	_5.09s	_5.19s
_{Emit Time}	_{3.48s (± 0.57%)}	_{3.48s (± 0.60%)}	_{+0.01s (+ 0.14%)}	_3.45s	_3.54s
_{Total Time}	_{10.42s (± 0.32%)}	_{10.49s (± 0.46%)}	_{+0.07s (+ 0.66%)}	_10.39s	_10.61s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{439,362k (± 0.02%)}	_{439,371k (± 0.01%)}	_{+8k (+ 0.00%)}	_439,315k	_439,567k
_{Parse Time}	_{1.72s (± 1.08%)}	_{1.74s (± 0.98%)}	_{+0.01s (+ 0.87%)}	_1.70s	_1.78s
_{Bind Time}	_{0.54s (± 0.74%)}	_{0.54s (± 0.55%)}	_{+0.00s (+ 0.56%)}	_0.54s	_0.55s
_{Check Time}	_{12.59s (± 0.78%)}	_{12.63s (± 1.05%)}	_{+0.04s (+ 0.31%)}	_12.49s	_13.13s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.86s (± 0.62%)}	_{14.91s (± 0.88%)}	_{+0.06s (+ 0.38%)}	_14.73s	_15.39s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{554,246k (± 0.01%)}	_{554,428k (± 0.01%)}	_{+182k (+ 0.03%)}	_554,292k	_554,615k
_{Parse Time}	_{2.30s (± 0.24%)}	_{2.30s (± 0.44%)}	_{+0.01s (+ 0.30%)}	_2.29s	_2.33s
_{Bind Time}	_{0.89s (± 2.09%)}	_{0.89s (± 1.38%)}	_{+0.01s (+ 0.68%)}	_0.88s	_0.94s
_{Check Time}	_{1.43s (± 0.48%)}	_{1.44s (± 0.93%)}	_{+0.02s (+ 1.33%)}	_1.40s	_1.47s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{4.68s (± 0.32%)}	_{4.71s (± 0.33%)}	_{+0.03s (+ 0.64%)}	_4.68s	_4.74s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-126-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₁₁₄₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-10-11T03:05:13Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/51140/merge:

Everything looks good!

ahejlsberg · 2022-10-11T23:41:44Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2022-10-11T23:41:47Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f0f853e. You can monitor the build here.

typescript-bot · 2022-10-11T23:41:47Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at f0f853e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-11T23:41:47Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at f0f853e. You can monitor the build here.

typescript-bot · 2022-10-11T23:41:47Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at f0f853e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-11T23:41:47Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at f0f853e. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-10-11T23:55:00Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/51140/merge:

Everything looks good!

typescript-bot · 2022-10-11T23:59:41Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51140

_Metric	_main	₅₁₁₄₀	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{352,356k (± 0.02%)}	_{352,340k (± 0.02%)}	_{-16k (- 0.00%)}	_352,159k	_352,504k
_{Parse Time}	_{1.90s (± 0.76%)}	_{1.88s (± 0.62%)}	_{-0.01s (- 0.69%)}	_1.86s	_1.91s
_{Bind Time}	_{0.74s (± 0.50%)}	_{0.75s (± 0.64%)}	_{+0.00s (+ 0.27%)}	_0.74s	_0.76s
_{Check Time}	_{5.69s (± 0.58%)}	_{5.69s (± 0.46%)}	_{+0.00s (+ 0.02%)}	_5.65s	_5.76s
_{Emit Time}	_{6.08s (± 0.52%)}	_{6.09s (± 0.58%)}	_{+0.01s (+ 0.21%)}	_6.02s	_6.15s
_{Total Time}	_{14.41s (± 0.37%)}	_{14.41s (± 0.36%)}	_{+0.00s (+ 0.00%)}	_14.30s	_14.51s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{198,243k (± 0.55%)}	_{198,072k (± 0.48%)}	_{-171k (- 0.09%)}	_197,376k	_200,648k
_{Parse Time}	_{0.78s (± 0.71%)}	_{0.79s (± 1.15%)}	_{+0.01s (+ 0.90%)}	_0.77s	_0.81s
_{Bind Time}	_{0.45s (± 0.75%)}	_{0.46s (± 1.27%)}	_{+0.00s (+ 0.88%)}	_0.45s	_0.47s
_{Check Time}	_{6.50s (± 0.43%)}	_{6.47s (± 1.01%)}	_{-0.03s (- 0.42%)}	_6.35s	_6.60s
_{Emit Time}	_{2.31s (± 0.72%)}	_{2.31s (± 0.73%)}	_{+0.00s (+ 0.09%)}	_2.27s	_2.36s
_{Total Time}	_{10.04s (± 0.34%)}	_{10.02s (± 0.72%)}	_{-0.02s (- 0.18%)}	_9.91s	_10.18s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{331,137k (± 0.01%)}	_{331,159k (± 0.01%)}	_{+22k (+ 0.01%)}	_331,071k	_331,236k
_{Parse Time}	_{1.43s (± 0.69%)}	_{1.43s (± 0.58%)}	_{+0.00s (+ 0.21%)}	_1.42s	_1.45s
_{Bind Time}	_{0.69s (± 0.81%)}	_{0.70s (± 0.98%)}	_{+0.01s (+ 1.16%)}	_0.68s	_0.71s
_{Check Time}	_{5.46s (± 0.56%)}	_{5.48s (± 0.48%)}	_{+0.02s (+ 0.40%)}	_5.44s	_5.55s
_{Emit Time}	_{3.26s (± 0.53%)}	_{3.27s (± 0.99%)}	_{+0.01s (+ 0.28%)}	_3.20s	_3.35s
_{Total Time}	_{10.84s (± 0.33%)}	_{10.88s (± 0.52%)}	_{+0.04s (+ 0.36%)}	_10.77s	_11.03s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{294,097k (± 0.01%)}	_{294,057k (± 0.02%)}	_{-40k (- 0.01%)}	_293,874k	_294,113k
_{Parse Time}	_{1.22s (± 1.33%)}	_{1.22s (± 1.56%)}	_{-0.00s (- 0.08%)}	_1.18s	_1.27s
_{Bind Time}	_{0.64s (± 0.74%)}	_{0.64s (± 0.78%)}	_{-0.01s (- 1.24%)}	_0.63s	_0.65s
_{Check Time}	_{5.12s (± 0.49%)}	_{5.11s (± 0.38%)}	_{-0.01s (- 0.20%)}	_5.07s	_5.15s
_{Emit Time}	_{3.49s (± 0.35%)}	_{3.47s (± 0.41%)}	_{-0.02s (- 0.52%)}	_3.45s	_3.50s
_{Total Time}	_{10.47s (± 0.46%)}	_{10.44s (± 0.37%)}	_{-0.03s (- 0.31%)}	_10.34s	_10.49s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{439,383k (± 0.02%)}	_{439,072k (± 0.01%)}	_{-311k (- 0.07%)}	_438,961k	_439,116k
_{Parse Time}	_{1.75s (± 1.06%)}	_{1.75s (± 0.78%)}	_{+0.01s (+ 0.34%)}	_1.71s	_1.77s
_{Bind Time}	_{0.54s (± 0.83%)}	_{0.54s (± 0.74%)}	_{+0.00s (+ 0.19%)}	_0.53s	_0.55s
_{Check Time}	_{12.50s (± 0.29%)}	_{12.55s (± 0.60%)}	_{+0.05s (+ 0.37%)}	_12.44s	_12.81s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{14.79s (± 0.24%)}	_{14.84s (± 0.54%)}	_{+0.05s (+ 0.36%)}	_14.72s	_15.13s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{554,341k (± 0.02%)}	_{554,500k (± 0.02%)}	_{+159k (+ 0.03%)}	_554,343k	_554,733k
_{Parse Time}	_{2.30s (± 0.35%)}	_{2.31s (± 0.36%)}	_{+0.01s (+ 0.39%)}	_2.30s	_2.34s
_{Bind Time}	_{0.89s (± 1.68%)}	_{0.89s (± 1.65%)}	_{-0.00s (- 0.23%)}	_0.87s	_0.94s
_{Check Time}	_{1.43s (± 0.42%)}	_{1.43s (± 0.82%)}	_{+0.00s (+ 0.35%)}	_1.40s	_1.45s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{4.69s (± 0.47%)}	_{4.70s (± 0.24%)}	_{+0.02s (+ 0.36%)}	_4.69s	_4.74s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-126-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₁₁₄₀	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-10-12T01:10:03Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/51140/merge:

Everything looks good!

DanielRosenwasser · 2022-10-12T20:15:57Z

src/compiler/checker.ts

                    }

-                    const isPerformingCommonPropertyChecks = (relation !== comparableRelation || !(source.flags & TypeFlags.Union) && isLiteralType(source)) &&
+                    const isPerformingCommonPropertyChecks = (relation !== comparableRelation || isUnitType(source)) &&


I believe the problem with isUnitType is that it doesn't consider enum literal types.

https://github.com/microsoft/TypeScript/pull/50423/files#r954112029

So we won't catch assignability from an enum literal to a weak type with no overlap.

enum E { A = "A" } // these will differ let x: { nope?: any } = E.A; let y: { nope?: any } = "A";

Enum literal types are definitely considered unit types. It's a bit subtle, isUnitType checks for TypeFlags.Unit, which includes TypeFlags.Literal, which includes TypeFlags.StringLiteral and TypeFlags.NumberLiteral. For enum literal types, the TypeFlags.EnumLiteral flag is always combined with one of the latter two, so isUnitType will always be true.

Just to be sure, I verified both of your examples generate errors.

Great! Can you add that as a test case?

ahejlsberg added 2 commits October 10, 2022 18:09

Check nested weak types in intersections on target side of relation

52e9cae

Add regression tests

72a0f3b

typescript-bot assigned ahejlsberg Oct 11, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 11, 2022

Move logic from isRelatedTo to structuredTypeRelatedTo

f0f853e

Fix lint error

0c690b0

DanielRosenwasser reviewed Oct 12, 2022

View reviewed changes

DanielRosenwasser approved these changes Oct 13, 2022

View reviewed changes

DanielRosenwasser mentioned this pull request Oct 13, 2022

Discard union types before considering weak type checks on unit-like types #50423

Merged

Add additional test

d899a4e

ahejlsberg merged commit 37317a2 into main Oct 13, 2022

ahejlsberg deleted the fix51043 branch October 13, 2022 15:20

jcalz mentioned this pull request Nov 21, 2022

Assignability of covariant types with bivariant methods now fails in certain intersection types #51620

Closed

Andarist mentioned this pull request Jan 1, 2023

Add tests for excess property check for intersection containing a recursive type #52063

Merged

Andarist mentioned this pull request Feb 12, 2023

Missing excess property errors when assigning to intersection #44942

Closed

Andarist mentioned this pull request Mar 5, 2023

Add an extra test for excess property check for intersection containing a recursive type #53100

Merged

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Check nested weak types in intersections on target side of relation #51140

Check nested weak types in intersections on target side of relation #51140

Uh oh!

Conversation

ahejlsberg commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahejlsberg commented Oct 11, 2022

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022

Uh oh!

typescript-bot commented Oct 11, 2022

Uh oh!

typescript-bot commented Oct 11, 2022

Uh oh!

ahejlsberg commented Oct 11, 2022

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 11, 2022

Uh oh!

typescript-bot commented Oct 11, 2022

Uh oh!

typescript-bot commented Oct 12, 2022

Uh oh!

DanielRosenwasser Oct 12, 2022

Choose a reason for hiding this comment

Uh oh!

ahejlsberg Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

ahejlsberg Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ahejlsberg commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading

typescript-bot commented Oct 11, 2022 •

edited

Loading