Skip to content

Conversation

@typescript-bot
Copy link
Collaborator

This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @microsoft/typescript

@typescript-bot typescript-bot force-pushed the user-baseline-updates branch from a23eb4b to 7dbdc64 Compare May 11, 2020 16:29
Type 'unknown' is not assignable to type '{ [K in keyof EventTypes]: any[] | ((...args: any[]) => void); }'.
Type 'EventTypes' is not assignable to type '{ [K in keyof EventTypes]: any[] | ((...args: any[]) => void); }'.
Type 'unknown' is not assignable to type '{ [K in keyof EventTypes]: any[] | ((...args: any[]) => void); }'.
node_modules/eventemitter3/index.d.ts(117,17): error TS2536: Type 'K' cannot be used to index type 'ArgumentMap<T>'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that's their current error. I am talking to the authors to help them repro this.

@sandersn sandersn merged commit 4109bba into microsoft:master May 11, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request May 12, 2020
* upstream/master: (54 commits)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Fix for jsdoc modifiers on constructor params (microsoft#38403)
  Improve assert message in binder (microsoft#38270)
  fix broken regex on "src/services/completions.ts#getCompletionData" (microsoft#37546)
  report error for duplicate @type declaration (microsoft#38340)
  fix(38073): hide 'Extract to function in global scope' action for arrow functions which use 'this' (microsoft#38107)
  Update user baselines (microsoft#38472)
  Update user baselines (microsoft#38405)
  Changed template strings to emit void 0 instead of undefined (microsoft#38430)
  Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit (microsoft#38368)
  LEGO: check in for master to temporary branch.
  Make isDynamicFileName available publicly (microsoft#38269)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Exclude arrays and tuples from full intersection property check (microsoft#38395)
  Fix crash caused by assertion with evolving array type (microsoft#38398)
  Update user baselines (microsoft#38128)
  LEGO: check in for master to temporary branch.
  moveToNewFile: handle namespace imports too
  ...

# Conflicts:
#	src/compiler/types.ts
#	src/compiler/utilities.ts
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants