Skip to content

Make javascript require goto def similar to ts import equals #36487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheetalkamat merged 1 commit into from
Jan 29, 2020
Merged

Make javascript require goto def similar to ts import equals #36487

sheetalkamat merged 1 commit into from
Jan 29, 2020

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Jan 28, 2020

Fixes #34996

@sheetalkamat sheetalkamat requested a review from sandersn January 28, 2020 23:08
@sheetalkamat sheetalkamat merged commit 869a821 into master Jan 29, 2020
@sheetalkamat sheetalkamat deleted the jsModuleGotoDef branch January 29, 2020 00:24
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn sandersn sandersn approved these changes

@amcasey amcasey Awaiting requested review from amcasey

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

@orta orta Awaiting requested review from orta

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Go to Definition on identifier should jump to require()'d path

4 participants

@sheetalkamat @sandersn @typescript-bot