Do not omit the anyFunctionType from intersections #35658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35390
We assume that if
getSignatureApplicabilityErrorproduces an error for a non-normal check mode, that underNormalcheck mode it will as well. In the example given in the issue,getSignatureApplicabilityErrorunderCheckMode.SkipContextSensitiveproduced an error result, because theonChangeproperty was an intersection type of theanyFunctionTypeand another type, which, when intersected just became that other type - this, in turn, caused an assignability error. UnderNormalmode, the context-sensitive function is checked, and found, when intersected with that type, to satisfy the relationship. Ergo, the correct fix is to preserve theanyFunctionTypein intersections (rather than omitting it as though it were an empty object), so its behavior can propagate.