Skip to content

Improve use of SemanticMeaning in symbol display #26953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 7, 2018
Merged

Improve use of SemanticMeaning in symbol display #26953

1 commit merged into from
Sep 7, 2018

Conversation

@ghost
Copy link

@ghost ghost commented Sep 7, 2018

  • Only set symbolKind to "function" if SemanticMeaning.Value is set.
  • Only display a type alias if SemanticMeaning.Type is set.
  • Handle this type correctly. (Previously was treated as a parameter.)
  • ExternalModuleReferences should have SemanticMeaning.All.

(Part of #13766)

@ghost ghost requested a review from sheetalkamat September 7, 2018 00:23
@ghost ghost merged commit cbde861 into master Sep 7, 2018
@ghost ghost deleted the symbolDisplayMeaning branch September 7, 2018 19:23
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sheetalkamat