Skip to content

Look at simplified types when checking distributive conditional constraints #23884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weswigham merged 1 commit into from
May 4, 2018
Merged

Look at simplified types when checking distributive conditional constraints #23884

weswigham merged 1 commit into from
May 4, 2018

Conversation

@weswigham
Copy link
Member

@weswigham weswigham commented May 4, 2018 •
edited
Loading

In #23592 we changed the getConstraintOfType function to not simplify index types - distributive conditional type constraints rely on the type being simplified to actually have something to iterate over, ergo getConstraintOfDistributiveConditionalType must call getSimplifiedType itself.

Fixes #23849

@weswigham weswigham requested review from ahejlsberg and mhegazy May 4, 2018 00:26
@weswigham weswigham mentioned this pull request May 4, 2018
Closed
@weswigham weswigham merged commit 618da24 into microsoft:master May 4, 2018
@weswigham weswigham deleted the conditional-constraint-distributivity branch May 4, 2018 21:35
@trshafer trshafer mentioned this pull request Jun 13, 2018
Closed
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ahejlsberg ahejlsberg ahejlsberg approved these changes

@mhegazy mhegazy Awaiting requested review from mhegazy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weswigham @ahejlsberg