Skip to content

Conversation

@sheetalkamat
Copy link
Member

May fix #21274

@sheetalkamat
Copy link
Member Author

@mjbvz @Tyriar could you please try out this branch to see if it helps with #21274

@mjbvz
Copy link
Contributor

mjbvz commented Jan 19, 2018

@Tyriar I'm actually not seeing the perf issue on my Mac. Could you please test out this branch:

  1. Check out this branch from the ts repo
  2. In the folder, run npm install and then gulp local to build a local ts version
  3. In VS Code, set add a user setting pointing to the tsdk build location, for example:"typescript.tsdk": "/Users/matb/projects/TypeScript/built/local"
  4. Restart vscode and make sure you are using the built-in version of TS

We can also take a look at this together tomorrow

@Tyriar
Copy link
Member

Tyriar commented Jan 19, 2018

I just set up the local build, will report back soon.

@Tyriar
Copy link
Member

Tyriar commented Jan 19, 2018

Nothing happened so far, so I guess it's fixed. The repro I had before happened about 5 minutes into opening VS Code, this happened 3 times in a row fairly consistently. Will ping back if I see it but I think this fixes the problem.

@sheetalkamat
Copy link
Member Author

@mhegazy can you please review this change, so we can take this in.

@sheetalkamat sheetalkamat merged commit 8c04540 into master Jan 19, 2018
@sheetalkamat sheetalkamat deleted the isEmittedFileCheckInInvalidateResolution branch January 19, 2018 21:04
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tsserver maxing out CPU "WatchType: Directory of Failed lookup locations in module resolution"

5 participants