Skip to content

Formatting failure for multiline jsx attribute #34982

@mjbvz

Description

@mjbvz

From microsoft/vscode#84095

TypeScript Version: 3.8.0-dev.20191105

Search Terms:

  • format / formatter / formatting
  • tsserver

Code
For the JSX:

(
    <input
        value="x
        x"
    />
);
  1. Run Format

Bug:

    Debug Failure. False expression: Token end is child end

    Error: Debug Failure. False expression: Token end is child end
        at processChildNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118096:34)
        at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118037:21
        at visitNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:17600:24)
        at Object.forEachChild (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:18009:21)
        at processNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118036:20)
        at processChildNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118102:21)
        at processChildNodes (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118153:48)
        at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118039:21
        at visitNodes (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:17605:24)
        at Object.forEachChild (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:18006:24)
        at processNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118036:20)
        at processChildNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118102:21)
        at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118037:21
        at visitNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:17600:24)
        at Object.forEachChild (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:18004:21)
        at processNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118036:20)
        at processChildNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118102:21)
        at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118037:21
        at visitNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:17600:24)
        at Object.forEachChild (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:17803:24)
        at processNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118036:20)
        at processChildNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118102:21)
        at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118037:21
        at visitNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:17600:24)
        at Object.forEachChild (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:17851:24)
        at processNode (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:118036:20)
        at formatSpanWorker (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:117851:17)
        at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:117832:208
        at Object.getFormattingScanner (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:116482:23)
        at formatSpan (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:117832:31)
        at Object.formatSelection (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:117650:20)
        at Object.getFormattingEditsForRange (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:131014:34)
        at IOSession.Session.getFormattingEditsForRange (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:140280:45)
        at Session.handlers.ts.createMapFromTemplate._a.<computed> (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:139320:61)
        at /Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:140870:88
        at IOSession.Session.executeWithRequestId (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:140861:28)
        at IOSession.Session.executeCommand (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:140870:33)
        at IOSession.Session.onMessage (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:140893:35)
        at Interface.<anonymous> (/Users/matb/projects/vscode/extensions/node_modules/typescript/lib/tsserver.js:142208:27)
        at Interface.emit (events.js:200:13)
        at Interface._onLine (readline.js:314:10)
        at Interface._normalWrite (readline.js:459:12)
        at Socket.ondata (readline.js:170:10)
        at Socket.emit (events.js:200:13)
        at addChunk (_stream_readable.js:294:12)
        at readableAddChunk (_stream_readable.js:275:11)
        at Socket.Readable.push (_stream_readable.js:210:10)
        at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)

Playground Link:

Related Issues:

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptDomain: FormatterThe issue relates to the built-in formatterFix AvailableA PR has been opened for this issue

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions