Exclude isn't working in TypeScript 2.0.2

[szykov]

TypeScript Version: 2.0.2

Code

tsconfig.json

{
  "compileOnSave": true,
  "compilerOptions": {
    "target": "es5",
    "module": "amd",
    "moduleResolution": "node",
    "sourceMap": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "removeComments": false,
    "noImplicitAny": false,
    "outDir": "wwwroot/js"
  },
  "include": [
    "./TypeScripts/**/*.ts"
  ],
  "exclude": [
    "node_modules",
    "Typings",
    "wwwroot"
  ]
}

In VS 2015 update 3 with TypeScript 2.0.2 tooling installed i'm facing an issue. I can't exclude my node_modules folder. When i start build my project it raises errors inside *.d.ts files which needed to be excluded.

In VS 2015 only TypeScript 2.0.2 tooling installed.
Command 'tsc -v' shows version 2.0.2.
Command 'tsc --project tsconfig.json' don't show any output.
Command 'dotnet build', 'dotnet run' don't produce any issue.

I'm having asp.net mvc core project with angular2.
Please help.

File structure:

wwwroot\node_modules - NOT EXCLUDED
wwwroot\Typings - OK
wwwroot\TypeScripts - OK
...
...
Typings - OK
node_modules - OK
...

Expected behavior:

Avoid and exclude wwwroot/node_modules ts files.

Actual behavior:

It tries to check ts files in the folder wwwroot/node_modules.

Workaround:

The workaround of this situation to remove wwwroot/node_modules folder. Start project in VS. Recreate wwwroot/node_modules folder with all files. Now everthing works even if rebuild project.

But if a restart VS then i will face the same behaviour.

[bondz]

Typescript 2 looks for declaration files in node_modules folder regardless of exclusion when --moduleResolution is set to node, you can see which files are checked with the --traceResolution option. One or more files there use implicit any which you have disabled in your configuration, one way to get around this for now is to use the --skipDefaultLibCheck or --skipLibCheck option in which case, you'd be losing some of the guarantees of TypeScript.

[mhegazy]

Do you have an import for this file, or a triple slash reference? see https://github.com/Microsoft/TypeScript/wiki/FAQ#why-is-a-file-in-the-exclude-list-still-picked-up-by-the-compiler

[szykov]

@bondz folowing your logic if i remove *.d.ts files in my 'wwwroot\node_modules' folder i should be fine.
and i did to try, but seems it didn't work. When I compile with removed declaration files, it still compiles *.ts files in the folder 'wwwroot\node_modules' because it starts raising errors in declaration files but now inside 'node_modules' folder which is located in my root folder.

Considering what wrote @mhegazy and what is written in the documentaion of how module resolution performs when I chose 'node' type it kinda makes logic for me.

What I see from my perspective that 'node_modules' which in the root folder is excluded fine. But 'wwwroot\node_modules' isn't excluded at all.

if i try to run:
'tsc wwwroot\node_modules...\foo.d.ts' - it raises erros.
'tsc node_modules...\foo.d.ts' - it raises erros.
'tsc --project tsconfig.json' - shows no erros.

if open my Visual Studio files:
'wwwroot\node_modules...\foo.d.ts' - raises errors in my IDE.
'node_modules...\foo.d.ts' - shows no errors. how?

All errors related to interfaces like 'map', 'promise', 'set'. which normally should be resolved by using es6-shim declaration files. But in my case i want VS to just ignore them. :\

[szykov]

Just tried --skipDefaultLibCheck and --skipLibCheck and it didn't work. :\

[bondz]

Oh, sorry, but I can't seem to reproduce the error in VSCode. Maybe if you can upload a sample?

[szykov]

@bondz this issue only impacts Visual Studio. I'll try to upload to github and let you know.

[szykov]

I just added my rep on github - https://github.com/szykov/WebServicesApp

1. Before compile in Visual Studio restore all npm/bower packages.
2. Run tsc.
3. Run typings install
4. Run task 'copy-npm' in gulp (it will copy some of the npm packages to 'wwwroot/node_modules').
5. Also i'm using .net core sdk, you need to install this one. And check that your installed version is the same as in global.json. otherwise you can fix global.json.

After that you may try to compile in Visual Studio.

[jsgoupil]

I'm having the exact same problem with my own repo since I updated to 2.0. I can compile fine from the commandline with tsc, but when I use Visual Studio, it parses the whole node_modules folders and start failing the compilation.

The workaround he proposes works. But what a pain...

I can repro with 2.0.3

[szykov]

@jsgoupil well written.

I can also confirm that upgrading typescript from 2.0.2 to 2.0.3 version didn't solve the issue and on typescript 1.8.6 i didn't have such issue. For some folks downgrading back to 1.8.6 would be a workaround also but not for me due that Angular 2 requires to have typesript 2 version.

[mhegazy]

@szykov, i am building this project just fine, I would appreciate the help figuring out what is going on. a few questions, if you run tsc as C:\Program Files (x86)\Microsoft SDKs\TypeScript\2.0\tsc.exe --project "c:\test\11055\WebServiceApp\src\WebServicesApp\tsconfig.json" do you see the same errors? if not can you share a build log with /verbosity: diagnostic? if yes can you share the errors?

[mhegazy]

@jsgoupil good to hear from you again, has been a while :).

Do you have a project i can look at?

[szykov]

@mhegazy seems it's always hard to repeat the error :) can you confirm that you used gulp task run copy-npm? When i run tsc.exe --project "tsconfig.json" - i'm fine. It produces no errors.

I attached files. Thanks.

errors.txt
output.txt

[jsgoupil]

@mhegazy My project is a little too big right now and I'm going on vacation. I took @szykov project and tried it and I can repro.

cd WebServiceApp\src\WebServicesApp
npm install
..\..\WebServicesApp.sln
CTRL+F5
// Success.
Close Visual Studio
gulp copy-npm
..\..\WebServicesApp.sln
CTRL+F5
// Fail

[basarat]

I see the same thing, I have a minimal repo which I try to exclude spec files and they still get compiled running tsc.

Exclude is misspelled : https://github.com/beckend/typescript-project-exclude/blob/bbc575c71030120aabf9b380222814bf5c9be74e/tsconfig.json#L20

Fix it and alm doesn't include the excluded files :