-
Notifications
You must be signed in to change notification settings - Fork 1.6k
P2321R2: Added std::views::zip
.
#3035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 113 commits
Commits
Show all changes
116 commits
Select commit
Hold shift + click to select a range
6585715
Added the std::views::zip implementation.
tylerbrawl 1982609
Fixed some rather sneaky errors.
tylerbrawl 2c8a884
Executed a ClangFormat formatting pass.
tylerbrawl c3eb358
Moved most implementation details into a different namespace.
tylerbrawl efe0b06
Added a work-around for P2165R4.
tylerbrawl 6eacd17
Fixed a minor bug with distance calculation.
tylerbrawl 4c3f04a
Fixed Clang compilation errors.
tylerbrawl ed15aca
Fixed more Clang compilation errors.
tylerbrawl 05a9cfb
Removed excessive use of _STD and _RANGES.
tylerbrawl dc66136
Removed _Zip::_Tuple_or_pair in favor of std::tuple.
tylerbrawl 409d39a
Fixed some formatting errors.
tylerbrawl 8932d3b
Fixed formatting (for real this time).
tylerbrawl 7ae33ec
Removed the speculative feature test macro.
tylerbrawl 77c6141
Refactored the implementation to remove recursion.
tylerbrawl 972a5be
Fixed some Clang compilation errors.
tylerbrawl c0f46a6
Merge pull request #1 from tylerbrawl/recursive-removal
tylerbrawl 4c97a8d
Reinstated the __cpp_lib_ranges_zip feature test macro.
tylerbrawl 2c59b35
Added __cpp_lib_ranges_zip to the VSO_0157762 test.
tylerbrawl 389fe1c
Updated the implemented feature list in yvals_core.h.
tylerbrawl e7e4eb5
Update stl/inc/yvals_core.h
tylerbrawl 70e2e38
Applied suggested changes from code review 1.
tylerbrawl ea0a6e6
Applied a formatting pass.
tylerbrawl 6a6007f
Merge pull request #2 from tylerbrawl/code-review-1
tylerbrawl c28843d
Removed _Zip::_Allow_views.
tylerbrawl f9cc980
Moved and renamed member variables for conformance.
tylerbrawl ccf498e
Added const for difference_type parameters.
tylerbrawl 443cf75
Merge pull request #3 from tylerbrawl/code-review-1
tylerbrawl 2413a20
Moved _Iterator_type further up in _Sentinel.
tylerbrawl 96ee337
Merge pull request #4 from tylerbrawl/code-review-1
tylerbrawl 1f726e4
Added the relevant files.
tylerbrawl 3705dfb
Merge branch 'main' into test-suite
tylerbrawl baeb38b
Added the first real set of tests.
tylerbrawl 48b3405
Added back commented tests.
tylerbrawl 40a1d45
Added back even more commented tests.
tylerbrawl b641627
Merge pull request #5 from tylerbrawl/test-suite
tylerbrawl 586f9fd
Fixed some formatting errors.
tylerbrawl 7ccfb04
Merge pull request #6 from tylerbrawl/test-suite
tylerbrawl 837533f
Added [[no_unique_address]] comments.
tylerbrawl 88c48f6
Merge pull request #7 from tylerbrawl/test-suite
tylerbrawl cab2d65
Reduced the number of generated tests.
tylerbrawl 6dc5ad2
Merge pull request #8 from tylerbrawl/test-suite
tylerbrawl 2b95bcb
Added the std::views::zip test to test.lst.
tylerbrawl c1ceef0
Merge pull request #9 from tylerbrawl/test-suite
tylerbrawl 394c41d
Update tests/std/tests/P2321R2_views_zip/test.cpp
tylerbrawl 9616eac
Applied some suggested style changes to test.cpp.
tylerbrawl 63b8d91
Merge pull request #10 from tylerbrawl/test-suite-style
tylerbrawl da8e159
Merge remote-tracking branch 'upstream/main' into pr/tylerbrawl/3035
strega-nil a5a5fa2
fix reference to P2165R4
strega-nil 51f67cd
Applied strega-nil-ms' first set of changes.
tylerbrawl c3f859a
Applied cpplearner's suggested changes.
tylerbrawl 32ce22e
Defined _Iterator and _Sentinel inline.
tylerbrawl 1d7176a
Renamed _Ranges to _Views in zip_view.
tylerbrawl ec9e878
Applied some minor changes.
tylerbrawl 1c5ca01
Applied more trivial code review suggestions.
tylerbrawl 6800ec2
Added the remainder of strega-nil-ms' suggestions.
tylerbrawl 95db9fd
Added namespace qualifiers to iter_move and iter_swap calls in test.cpp.
tylerbrawl dff0535
Added clarification for the use of the strict testing matrix.
tylerbrawl b6f717e
Added back some removed tests.
tylerbrawl b30cb70
Merge pull request #11 from tylerbrawl/code-review-2
tylerbrawl 7721522
Fixed some formatting errors.
tylerbrawl 63c06c3
Merge pull request #12 from tylerbrawl/code-review-2
tylerbrawl 5647852
Applied some more suggestions.
tylerbrawl 003a62a
Fixed some missing test code paths.
tylerbrawl 37a0fb2
Modified yvals_core for consistency.
tylerbrawl a0bebe7
Removed explicit `std::` prefixes in the test code.
tylerbrawl 9ed6849
Fixed a ridiculous formatting error.
tylerbrawl 3cf01cb
Merge pull request #13 from tylerbrawl/code-review-3
tylerbrawl 6d2ebbc
Modularized the zip test to fix compiler crashed and increase through…
tylerbrawl 9d15eb0
Fixed the return type of a function.
tylerbrawl b454a76
Merge pull request #14 from tylerbrawl/code-review-3
tylerbrawl c62bf57
Even the .lst files need formatting...
tylerbrawl 2dd2f08
Merge pull request #15 from tylerbrawl/code-review-3
tylerbrawl e2b8fa3
Merge branch 'microsoft:main' into main
tylerbrawl f5000ee
Added `_EXPORT_STD` for the `std` module.
tylerbrawl d261bb8
Merge pull request #16 from tylerbrawl/modules-support
tylerbrawl 364c7e3
Moved `_Zip_fn` into `std::views` for consistency with `_Meow_fn`.
tylerbrawl b724bd0
Merge pull request #17 from tylerbrawl/zip-fn-in-views
tylerbrawl ddba898
CRs
strega-nil d8a63a5
lambda -> closure
strega-nil 8d58992
algorithm was, in fact, required.
strega-nil fc8c01e
Merge branch 'microsoft:main' into main
tylerbrawl 586e1eb
Moved `ranges::max` and `ranges::min` to `<xutility>`.
tylerbrawl 664930c
Implemented suggested changes from StephenTLavavej.
tylerbrawl 22ca087
Fixed some compilation errors found in testing.
tylerbrawl dfb5a2e
Merge pull request #18 from tylerbrawl/code-review-4
tylerbrawl 2e05705
I forgot to format the test suite...
tylerbrawl 972baec
Merge pull request #19 from tylerbrawl/code-review-4
tylerbrawl 5ed5d17
Revert an accidental LLVM update...
tylerbrawl f5a90ce
Merge pull request #20 from tylerbrawl/code-review-4
tylerbrawl ead1f72
Added most libc++ tests for zip_view.
tylerbrawl 40ef315
Merge pull request #21 from tylerbrawl/code-review-4
tylerbrawl b8b9ccd
Add missing semicolon.
StephanTLavavej ae02fa3
Sort by iterator strength.
StephanTLavavej 282af2f
Mirror changes to skipped_tests.txt.
StephanTLavavej e4d1a99
Remove clang-format suppression, no changes or improved formatting.
StephanTLavavej c73ebf8
Use _Off and _Where instead of _STD declval<difference_type>().
StephanTLavavej 28096b9
Use lvalue references so declval will match the expressions.
StephanTLavavej 455bb9d
Omit unnecessary `inline`.
StephanTLavavej c56cb2b
Use zip_view's injected-class-name.
StephanTLavavej 181f8b7
Use more _Maybe_const in _Is_end_noexcept.
StephanTLavavej a2f6298
Add _NODISCARD to _Zip_fn's _Is_invocation_noexcept and operator().
StephanTLavavej b088079
Include more headers.
StephanTLavavej c935e50
Simplify with min(initializer_list).
StephanTLavavej 3c6625d
Avoid unnecessary copies by taking const array&.
StephanTLavavej e8963f0
Style: Omit parens in return.
StephanTLavavej 0c804a6
Naming: Take `ranges` plural.
StephanTLavavej 6b59620
Add missing as_const to as_const(zipped_range).size().
StephanTLavavej 66fcece
Remove forced wrapping and suppression; clang-format 15 does a good job.
StephanTLavavej 7b2e4b1
Remove hyphen from "postfix", add "the".
StephanTLavavej 450cb3e
Reorder LocalZipType before ArrayType to match function parameters.
StephanTLavavej 02bd609
The primary template range_type_solver<IsMoveOnly> should be the true…
StephanTLavavej 31e6d91
Style: Use braces to construct temporary tuple.
StephanTLavavej fa55122
Fix and test noexcept strengthening.
StephanTLavavej ae9175e
Work around VSO-1655299 "C1XX Assertion failed: HasAnyErrors() || Has…
StephanTLavavej 00c33f0
Perma-workaround VSO-1655455 "C1XX Assertion failed: FATAL_UNREACHABL…
StephanTLavavej 573b546
Work around VSO-1655459 'C1XX Assertion failed: !"If lookup found RDS…
StephanTLavavej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Copyright (c) Microsoft Corporation. | ||
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
||
# NOTE: zip_view::_Iterator defines ADL overloads for iter_swap and iter_move, | ||
# so the test fails to compile unless /permissive- is set. This issue isn't | ||
# unique to zip_view; all view types whose iterators define overloads for these | ||
# functions have this requirement. | ||
RUNALL_INCLUDE ..\strict_concepts_latest_matrix.lst | ||
CaseyCarter marked this conversation as resolved.
Show resolved
Hide resolved
|
||
RUNALL_CROSSLIST | ||
PM_CL="/DTEST_INPUT" | ||
PM_CL="/DTEST_FORWARD" | ||
PM_CL="/DTEST_BIDIRECTIONAL" | ||
PM_CL="/DTEST_RANDOM" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.