feat: Json upload setting page #371

blessing-sanusi · 2025-08-07T19:09:17Z

Purpose

...

Does this introduce a breaking change?

Yes
No

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

microsoft-github-policy-service · 2025-08-07T19:09:29Z

@blessing-sanusi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copilot

Pull Request Overview

This PR implements JSON team configuration upload functionality, allowing users to upload custom team configurations and select teams for plan creation. The feature includes team management UI components, RAI validation for uploaded content, and backend support for team configuration processing.

Adds team upload and selection interface with validation
Integrates team selection into the plan creation workflow
Implements RAI validation for team configuration content

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/frontend/src/services/TeamService.ts	New service for team operations (upload, fetch, delete)
src/frontend/src/services/TaskService.tsx	Added team_id parameter to plan creation
src/frontend/src/pages/HomePage.tsx	Integrated team selection and upload functionality
src/frontend/src/components/common/SettingsButton.tsx	New team management UI component
src/frontend/src/models/Team.ts	Team data models and interfaces
src/backend/utils_kernel.py	RAI validation function for team configurations
src/backend/app_kernel.py	Added RAI validation to upload endpoint

Comments suppressed due to low confidence (1)

src/frontend/src/components/common/SettingsButton.tsx:136

The agent type name has a typo: "MaintanceKBAgent" should be "MaintenanceKBAgent" (missing 'e' in 'Maintenance')

    setIsOpen(false);

Copilot · 2025-08-11T08:28:01Z

src/frontend/src/models/enums.tsx

+    FILE_SURFER = "FileSurfer",
+    WEB_SURFER = "WebSurfer",
+    SENSOR_SENTINEL = "SensorSentinel",
+    MAINTENANCE_KB_AGENT = "MaintanceKBAgent",


The agent type name has a typo: "MaintanceKBAgent" should be "MaintenanceKBAgent" (missing 'e' in 'Maintenance')

Suggested change

MAINTENANCE_KB_AGENT = "MaintanceKBAgent",

MAINTENANCE_KB_AGENT = "MaintenanceKBAgent",

Copilot · 2025-08-11T08:28:02Z

src/frontend/src/models/enums.tsx

+    PLANNER = "Planner_Agent",
+
+    // Common uploadable agent types
+    MAGENTIC_ONE = "MagenticOne",


The agent type name appears to have a typo: "MagenticOne" should likely be "MagneticOne" (missing 'i' in 'Magnetic')

Suggested change

MAGENTIC_ONE = "MagenticOne",

MAGNETIC_ONE = "MagneticOne",

Copilot · 2025-08-11T08:28:02Z

src/frontend/src/models/enums.tsx

+            return 'system';
+        }
+
+        // MagenticOne framework agents


The comment has a typo: "MagenticOne" should likely be "MagneticOne" (missing 'i' in 'Magnetic')

Suggested change

// MagenticOne framework agents

// MagneticOne framework agents

Copilot · 2025-08-11T08:28:02Z

src/frontend/src/models/enums.tsx

+        // MagenticOne framework agents
+        if (typeStr === 'MagenticOne' || [
+            'Coder', 'Executor', 'FileSurfer', 'WebSurfer'
+        ].includes(typeStr)) {
+            return 'magentic-one';


The agent type comparison has a typo: "MagenticOne" should likely be "MagneticOne" (missing 'i' in 'Magnetic')

Suggested change

// MagenticOne framework agents

if (typeStr === 'MagenticOne' || [

'Coder', 'Executor', 'FileSurfer', 'WebSurfer'

].includes(typeStr)) {

return 'magentic-one';

// MagneticOne framework agents

if (typeStr === 'MagneticOne' || [

'Coder', 'Executor', 'FileSurfer', 'WebSurfer'

].includes(typeStr)) {

return 'magnetic-one';

Copilot · 2025-08-11T08:28:03Z

src/frontend/src/models/enums.tsx

+        if (typeStr === 'MagenticOne' || [
+            'Coder', 'Executor', 'FileSurfer', 'WebSurfer'
+        ].includes(typeStr)) {
+            return 'magentic-one';


The category name has a typo: "magentic-one" should likely be "magnetic-one" (missing 'i' in 'magnetic')

Suggested change

if (typeStr === 'MagenticOne' || [

'Coder', 'Executor', 'FileSurfer', 'WebSurfer'

].includes(typeStr)) {

return 'magentic-one';

if (typeStr === 'MagneticOne' || [

'Coder', 'Executor', 'FileSurfer', 'WebSurfer'

].includes(typeStr)) {

return 'magnetic-one';

Copilot · 2025-08-11T08:28:03Z

src/frontend/src/models/enums.tsx

+        switch (category) {
+            case 'system':
+                return 'Person';
+            case 'magentic-one':


The category case has a typo: "magentic-one" should likely be "magnetic-one" (missing 'i' in 'magnetic')

Suggested change

case 'magentic-one':

case 'magnetic-one':

Copilot · 2025-08-11T08:28:03Z

src/frontend/src/components/common/SettingsButton.tsx

+      // First, validate the file type
+      if (!file.name.toLowerCase().endsWith('.json')) {
+        throw new Error('Please upload a valid JSON file');


File type validation relies only on file extension which can be easily bypassed. Consider also validating the actual file content or MIME type for better security.

Suggested change

// First, validate the file type

if (!file.name.toLowerCase().endsWith('.json')) {

throw new Error('Please upload a valid JSON file');

// First, validate the file type by extension and MIME type

const validMimeTypes = ['application/json', 'text/json'];

if (

!file.name.toLowerCase().endsWith('.json') ||

(file.type && !validMimeTypes.includes(file.type))

) {

throw new Error('Please upload a valid JSON file (with .json extension and correct file type)');

Copilot · 2025-08-11T08:28:04Z

src/frontend/src/services/TeamService.ts

+            // Check if this is an RAI validation error
+            const errorDetail = error.response?.data?.detail || error.response?.data;
+
+            // If the error message contains "inappropriate content", treat it as RAI error
+            if (typeof errorDetail === 'string' && errorDetail.includes('inappropriate content')) {
+                return {
+                    success: false,
+                    raiError: {
+                        error_type: 'RAI_VALIDATION_FAILED',


Using string matching to detect RAI errors is fragile and could break if error messages change. Consider using structured error codes or types instead.

Suggested change

// Check if this is an RAI validation error

const errorDetail = error.response?.data?.detail || error.response?.data;

// If the error message contains "inappropriate content", treat it as RAI error

if (typeof errorDetail === 'string' && errorDetail.includes('inappropriate content')) {

return {

success: false,

raiError: {

error_type: 'RAI_VALIDATION_FAILED',

// Check if this is an RAI validation error using structured error code

const errorType = error.response?.data?.error_type;

const errorDetail = error.response?.data?.detail || error.response?.data?.message || error.response?.data;

if (errorType === 'RAI_VALIDATION_FAILED') {

return {

success: false,

raiError: {

error_type: errorType,

…e AI Foundry - Add POST /api/upload_team_config endpoint for team configuration management - Implement FoundryAgentService for bulk agent creation with error handling - Add comprehensive RAI validation for all uploaded content - Add team selection UI with search, delete, and validation features - Add model deployment and search index validation services

Fr4nc3 · 2025-08-12T18:33:12Z

src/frontend/src/services/TeamService.ts

@@ -0,0 +1,103 @@
+import { TeamConfig } from '../models/Team';


convert this file to tsx

Fr4nc3 · 2025-08-12T18:34:15Z

src/frontend/src/models/messages.tsx

@@ -83,7 +83,7 @@ export interface ActionRequest {
    /** Action to be performed */
    action: string;
    /** Agent assigned to this step */
-    agent: AgentType;
+    agent: AgentTypeString;


can you put back the AgentType instead of AgentTypeString

Fr4nc3 · 2025-08-12T18:34:27Z

src/frontend/src/models/homeInput.tsx

 }

-export const quickTasks: QuickTask[] = [
-    {


Fr4nc3 · 2025-08-12T18:36:00Z

src/frontend/src/models/enums.tsx

+    RAG = "RAG",
+
+    // Specific agent names (can be any name with any type)
+    CODER = "Coder",


this are not agent type,
Agent Type can be Custom, RAG, MagenticOne the other are Agent names

Fr4nc3 · 2025-08-12T18:54:54Z

src/backend/app_kernel.py

@@ -1526,6 +1629,160 @@ async def upload_team_config_endpoint(request: Request, file: UploadFile = File(
        raise HTTPException(status_code=500, detail="Internal server error occurred")


+@app.post("/api/upload_scenarios")


what are sceenarios?? I don't think we upload scenarios by themselves but as part of the teams only

take endpoint out

Fr4nc3 · 2025-08-12T18:56:44Z

src/backend/services/model_validation_service.py

+    """Service for validating model deployments in Azure AI Foundry"""
+
+    def __init__(self):
+        self.subscription_id = os.getenv("AZURE_AI_SUBSCRIPTION_ID")


this should come from the configuration file

Fr4nc3 · 2025-08-12T18:57:06Z

src/backend/services/search_validation_service.py

+
+    def __init__(self):
+        """Initialize the search validation service."""
+        self.search_endpoint = os.getenv("AZURE_SEARCH_ENDPOINT")


this should come from the validation file

Fr4nc3 · 2025-08-12T19:06:49Z

src/frontend/src/models/Team.ts

+export interface Agent {
+    input_key: string;
+    type: string;
+    name: string;


they should be tsx extension

Fr4nc3 · 2025-08-12T19:08:34Z

src/frontend/src/models/enums.tsx

+    PLANNER = "Planner_Agent",
+
+    // Common uploadable agent types
+    MAGENTIC_ONE = "MagenticOne",


Magentic one is not a name of Agent is a Agent Type, however, I think we will review this complete logic because in V3 the agent type are the agent names, and agent type will MagenticOne, Custom, and RAG

blessing-sanusi added 4 commits August 5, 2025 17:42

setting page

48ef9f7

Merge branch 'macae-v3-dev' into json-upload-settingPage

e3a40b9

setting page

b9509b0

team's upload and team's id passed

2c79c57

blessing-sanusi requested review from Avijit-Microsoft, Roopan-Microsoft, Prajwal-Microsoft, marktayl1, Fr4nc3, Vinay-Microsoft and aniaroramsft as code owners August 7, 2025 19:09

blessing-sanusi added 4 commits August 7, 2025 15:21

RAI validation

7b15649

team_id passed input_task object

81f64e0

json upload files

5c608e3

json upload files

8f0edcb

Ravikirana-Microsoft requested a review from Copilot August 11, 2025 08:25

Copilot AI reviewed Aug 11, 2025

View reviewed changes

blessing-sanusi added 2 commits August 11, 2025 18:10

json upload files authentications, deletion and model validation

fbc261e

Fr4nc3 reviewed Aug 12, 2025

View reviewed changes

blessing-sanusi added 2 commits August 12, 2025 17:47

json upload files authentications, deletion and model validation

b129362

change agentTypeString to AgentType

0699ef8

	MAINTENANCE_KB_AGENT = "MaintanceKBAgent",
	MAINTENANCE_KB_AGENT = "MaintenanceKBAgent",

	// MagenticOne framework agents
	// MagneticOne framework agents

-      // First, validate the file type
-      if (!file.name.toLowerCase().endsWith('.json')) {
-        throw new Error('Please upload a valid JSON file');
+      // First, validate the file type by extension and MIME type
+      const validMimeTypes = ['application/json', 'text/json'];
+      if (
+        !file.name.toLowerCase().endsWith('.json') ||
+        (file.type && !validMimeTypes.includes(file.type))
+      ) {
+        throw new Error('Please upload a valid JSON file (with .json extension and correct file type)');

		@@ -0,0 +1,103 @@
		import { TeamConfig } from '../models/Team';

		@@ -1526,6 +1629,160 @@ async def upload_team_config_endpoint(request: Request, file: UploadFile = File(
		raise HTTPException(status_code=500, detail="Internal server error occurred")


		@app.post("/api/upload_scenarios")

feat: Json upload setting page #371

Are you sure you want to change the base?

feat: Json upload setting page #371

Uh oh!

Conversation

blessing-sanusi commented Aug 7, 2025

Purpose

Does this introduce a breaking change?

How to Test

What to Check

Other Information

Uh oh!

microsoft-github-policy-service bot commented Aug 7, 2025

Contribution License Agreement

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!