Skip to content

Fix(MInference): fix get config #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix(MInference): fix get config #121

merged 1 commit into from
Feb 12, 2025

Conversation

iofu728
Copy link
Collaborator

@iofu728 iofu728 commented Feb 12, 2025

What does this PR do?

Fixes #119, fix get config

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue? Please add a link [Bug]: config["best_pattern"] cannot be loaded correctly #119
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@iofu728

@iofu728 iofu728 self-assigned this Feb 12, 2025
@iofu728 iofu728 requested a review from Copilot February 12, 2025 06:06
@iofu728 iofu728 added the bug Something isn't working label Feb 12, 2025
Copilot
Copilot AI reviewed Feb 12, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@iofu728 iofu728 merged commit 8863f20 into main Feb 12, 2025
1 check passed
@iofu728 iofu728 deleted the hjiang/fix_requirments branch February 12, 2025 06:07
@iofu728 iofu728 mentioned this pull request Feb 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@iofu728 iofu728

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: config["best_pattern"] cannot be loaded correctly
1 participant
@iofu728