Fix for vscode-cpptools/#2492 #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The other option is to refactor TryFindString to return a boolean and take an out parameter, but thats a more invasive fix, but it would be the right thing to do. If we want to go that route instead, let me know and I can update the code instead for that solution. |
pieandcakes
force-pushed
the
users/piel/fixerrormsg
branch
from
5d302f4 to
9e274c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in lldb-mi there appears to be "message" instead of "msg" when an error is returned in the
-exec-*command results. This is to handle both cases.Fixes microsoft/vscode-cpptools#2492