[test][python] fix pandas DeprecationWarning about is_sparse function
#6532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
borchero
as code owners
jameslamb
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Awesome, thanks!
And thank you for the research. We do now also have CI jobs testing against the oldest versions of Python dependencies:
LightGBM/.github/workflows/python_package.yml
Line 120 in 4292b16
and the latest (even pre-released) versions:
Thank you for letting me know! That's great! |
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following error:
LightGBM requires pandas>=0.24.0
LightGBM/python-package/pyproject.toml
Lines 44 to 46 in 6c76b6b
So I checked that
pd.SparseDtypeis available in that version:https://pandas.pydata.org/pandas-docs/version/0.24/reference/api/pandas.SparseDtype.html
Also, they've been performing
isinstancecheck under the hood since the begging:https://github.com/pandas-dev/pandas/blob/83eb2428ceb6257042173582f3f436c2c887aa69/pandas/core/dtypes/common.py#L216-L219