Skip to content

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Jun 21, 2024

Proposes removing a workaround in CI scripts that has been in place since #1606.

The code removed here sets up some symlinks that make it look like, for example, libgomp.dylib (GNU OpenMP) is libomp.dylib (the SONAME used by LLVM OpenMP). This was a workaround for some conflicts between OpenMP implementations that were showing up together (I think).

Removing it to simplify CI scripts, and because:

  • it should no longer be necessary (since [ci] [python-package] add arm64 macOS wheels #6391 prevents LightGBM from loading another libomp.dylib into an process that already has one loaded)
  • this workaround risks LightGBM accidentally linking against a library we don't intend for it to link against
    • (e.g. macOS wheels should be linked against libomp, LLVM OpenMP)

Notes for Reviewers

For more conversation on this, see #6489.

@jameslamb jameslamb changed the title WIP: [ci] remove OpenMP / MKL workaround in CI jobs [ci] remove OpenMP / MKL workaround in CI jobs Jun 21, 2024
@jameslamb jameslamb marked this pull request as ready for review June 21, 2024 06:04
@jameslamb jameslamb merged commit c4e70f3 into master Jun 21, 2024
@jameslamb jameslamb deleted the ci/remove-omp-workarond branch June 21, 2024 15:27
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants