Skip to content

Conversation

@jozkee
Copy link
Member

@jozkee jozkee commented May 6, 2025

@elbruno, please take a look.

@github-actions
Copy link

github-actions bot commented May 6, 2025

👋 Thanks for contributing @jozkee! We will review the pull request and get back to you soon.

@github-actions github-actions bot requested a review from elbruno May 6, 2025 21:26
@elbruno elbruno requested a review from Copilot May 9, 2025 20:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to M.E.AI version 9.4.3-preview.1.25230.7 by updating package reference versions and aligning API method calls with the latest conventions. Key changes include:

  • Upgrading package references across multiple projects.
  • Updating API calls from AsChatClient to AsIChatClient and modifying response property accesses.
  • Renaming streaming API methods to reflect the updated library guidelines.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
03-CoreGenerativeAITechniques/src/Vision-03MEAI-AOAI/Program.cs Updated API chain for chat client and streaming response call.
03-CoreGenerativeAITechniques/src/Vision-02MEAI-Ollama/Vision-02MEAI-Ollama.csproj Package version update.
03-CoreGenerativeAITechniques/src/Vision-02MEAI-Ollama/Program.cs Modified response assignment and comment update.
03-CoreGenerativeAITechniques/src/Vision-01MEAI-GitHubModels/* Upgraded csproj and API client usage.
03-CoreGenerativeAITechniques/src/RAGSimple-* Upgraded package references to new version.
03-CoreGenerativeAITechniques/src/MEAIFunctions* Updated API chaining and response property change.
03-CoreGenerativeAITechniques/src/DockerModels-02-MEAI-Chat/* Package reference update.
03-CoreGenerativeAITechniques/src/BasicChat-* Updated method calls and response property usage.
02-SetupDevEnvironment/src/BasicChat-* Updated API client instantiation and response printing.
Comments suppressed due to low confidence (4)

03-CoreGenerativeAITechniques/src/Vision-03MEAI-AOAI/Program.cs:45

  • The updated chaining using .GetChatClient(modelId) followed by .AsIChatClient() reflects the new API. Please verify that this change fully aligns with the updated library guidelines for obtaining a chat client.
.GetChatClient(modelId)

03-CoreGenerativeAITechniques/src/Vision-03MEAI-AOAI/Program.cs:75

  • Replacing CompleteStreamingAsync with GetStreamingResponseAsync appears to follow the new API design; ensure the behavior and return type semantics remain consistent with previous usage.
var completionUpdates = chatClient.GetStreamingResponseAsync(messages);

03-CoreGenerativeAITechniques/src/Vision-01MEAI-GitHubModels/Program.cs:17

  • The change from AsChatClient to AsIChatClient should ensure stricter type safety with the new API; double-check that all client interactions are adjusted accordingly.
.AsIChatClient("gpt-4o-mini");

02-SetupDevEnvironment/src/BasicChat-01MEAI/Program.cs:8

  • Updating the client instantiation to use AsIChatClient and printing response.Text instead of response.Message reflects the API update; ensure that downstream processing of responses adapts to this change.
.AsIChatClient("Phi-3.5-MoE-instruct");

@elbruno elbruno merged commit 010ec51 into microsoft:main May 9, 2025
3 checks passed
@jozkee jozkee deleted the update-meai-9.4.3-preview.1.25230.7 branch May 9, 2025 20:58
@jozkee jozkee restored the update-meai-9.4.3-preview.1.25230.7 branch May 13, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants