Issue with PreAdjustStockCountLineQuantityTrigger not being hit.

[MBoending]

Hi Everyone

I am trying to make some validation logic, preventing high numbers (usually from a barcode scan) ending up in the quantity field...

My strategy to do this, is having some validation logic on the PreAdjustStockCountLineQuantityTrigger.

When I put a breakpoint on the first line in the execute-method, it is never being hit.

Is there something wrong with my logic:

My trigger looks like this:
import * as Triggers from "PosApi/Extend/Triggers/StockCountTriggers";
import { CancelableTriggerResult } from "PosApi/Extend/Triggers/Triggers";
import { IExtensionContext } from "PosApi/Framework/ExtensionContext";
import MessageDialog from "../Controls/MessageDialog";

export default class PreAdjustStockCountLineQuantityTrigger extends Triggers.PreAdjustStockCountLineQuantityTrigger {
public execute(options: Triggers.IPreAdjustStockCountLineQuantityTriggerOptions): Promise<CancelableTriggerResult<Triggers.IPreAdjustStockCountLineQuantityTriggerOptions>> {
this.context.logger.logVerbose("Executing PreAdjustStockCountLineQuantityTrigger with options " + JSON.stringify(options) + " at " + new Date().getTime() + ".");

    let quantityCheck: boolean;

    let _context: IExtensionContext = this.context;
    let result: CancelableTriggerResult<Triggers.IPreAdjustStockCountLineQuantityTriggerOptions> = {
        canceled: false,
        options: options
    };
    if (Math.abs(options.adjustedQuantity) > 100000) {
        quantityCheck = false;

    }

    if (!quantityCheck) {
        let dialog = new MessageDialog();
        var message: string = _context.resources.getString("StockCountQuantityLimitExceeded");
        dialog.show(_context, message, _context.resources.getString("StockCountQuantityLimitExceededTitle"))
            .then((userConfirmed) => {
                if (!userConfirmed) {
                    result = {
                        canceled: false,
                        options: options
                    }
                }
            });

        return Promise.resolve(result);
    } else {
        return Promise.resolve(result);
    }
}

}

[madyke]

Hello @MBoending - this sounds more like an issue with loading the trigger extension rather than any problems with the logic in the extension trigger itself. Do you see your extension trigger being loaded in Store Commerce when you're testing it? It should be listed under Extensions on the Settings page. If you don't see it, these docs can help show you how to set up the extension:

• POS extension overview
• Create a POS extension package project
• Triggers Sample

[MBoending]

Hello @madyke

I will agree with your assesment... indeed it sounds like that... But it actually does register and also loads with Success.

On top of that, I have, (as you can see on the screenshot below)... setup triggers on PreSaveStockCountJournal which also did not work... But the one on PreOperation works just fine. So I wonder why those two related to Stocks does not fire.

[MBoending]

Hi again @madyke

My repro steps are:

1. Click Stock Count in Store Commerce's Home Menu
   

2. Select a journal (You might need to create a counting journal first i D365FO), and click View Details
   

3. Select a Journal Line
   

4. Click the Counting Now field to the right:
   

5. Update the Quantity and hit enter
   

I would assume this should trigger the PreAdjustStockCountLineQuantity, so I can have my validation there. Preventing the user from accidentally scanning a barcode in this field. But it does not seem to trigger though... which is my reason behind this ticket.

[madyke]

Thanks, I'll take a look on my machine and see if I can repro the issue

[madyke]

Ok, from digging into the code it looks like it's expected that the repro steps you explained would not fire the trigger, because that is modifying an InventoryDocument rather than the StockCountDetails that the triggers are associated with.

I'm not very familiar with this area of the product, so let me check with the Merchandising team to see what the expected flow is to modify the StockCountDetails and fire the triggers, or if there's another way to implement your requirements, and I'll get back to you.

[madyke]

Hi @MBoending - I think I found the root cause. It looks like a couple of years ago, there was an update made to the Stock Counting operation that provided a refreshed and improved UI experience. Unfortunately, as a part of that transition it seems that the PreAdjustStockCountLineQuantityTrigger was missed and is not available in the new experience.

Given that this functionality has been missing for a while without anyone noticing before, and since it would take some engineering to integrate the trigger into the new Stock Counting experience or add a new trigger with similar functionality, you will need to file an extensibility request if this is an extension point you want to see added to the product:
Extensibility requests