Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Dec 9, 2021

Description

Fixes the following keyboard navigation issues:

  • On "Configure your bot" screen, "Development Resources" tab keyboard focus gets lost after closing modals. The issue happens because modal trigger buttons get disabled when "Set up Language Understanding" and "Set up QnA Maker" modals are opened. Removed modal trigger buttons disabling logic to fix the issue.
  • On "Publish your bots" screen, "Publish" tab, "Publish target" drop-down causes navigation to the "Publishing profile" tab when it receives a focus event. The issue is caused by Dropdown component triggering onChange handler when keyboard focus received. Fixed by ignoring focus events for the particular "Manage profiles" drop-down item. Turned the drop-down to controlled one, so it always follows item.publishTarget selection rather internal state which allowed "Manage profiles" to be selected.

Task Item

Screenshots

preserve-focus-on-modals-kb webm
fix-publish-profile-kb webm

@ghost
Copy link

ghost commented Dec 9, 2021

CLA assistant check
All CLA requirements met.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 24b070b into microsoft:main Dec 16, 2021
@OEvgeny OEvgeny deleted the a11y/keyboard-focus-1 branch December 16, 2021 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants