-
Notifications
You must be signed in to change notification settings - Fork 472
Open
Description
Pull Request Overview
This PR adds help center URL fallback functionality for disabled walkthroughs in Cursor. Instead of trying to open the walkthrough when it's not supported (specifically in Cursor), the system will redirect users to relevant Help Center pages.
Key changes include:
- Refactoring walkthrough-related code to always instantiate the walkthrough service regardless of support status
- Adding fallback URL mappings and telemetry tracking for when help center URLs are used instead of walkthroughs
- Moving walkthrough context keys to a shared constants file for better organization
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/webviews/home/protocol.ts | Adds walkthrough state tracking to the home webview protocol |
src/webviews/home/homeWebview.ts | Refactors walkthrough progress handling to always provide state data |
src/webviews/apps/home/components/onboarding.ts | Enhances onboarding component with detailed walkthrough progress display |
src/telemetry/walkthroughStateProvider.ts | Moves type definitions and adds state getter method |
src/plus/launchpad/launchpadIndicator.ts | Removes conditional walkthrough support checks |
src/plus/launchpad/launchpad.ts | Removes conditional walkthrough support checks |
src/plus/gk/subscriptionService.ts | Removes conditional walkthrough support checks |
src/container.ts | Always instantiates walkthrough service |
src/constants.walkthroughs.ts | New file defining walkthrough context keys and progress steps |
src/constants.ts | Adds help center URLs for walkthrough fallbacks |
src/constants.telemetry.ts | Moves walkthrough context keys import and adds fallback URL tracking |
src/constants.context.ts | Updates walkthrough context keys import |
src/commands/walkthroughs.ts | Implements help center URL fallback logic with telemetry |
src/commands/quickCommand.steps.ts | Removes conditional walkthrough support check |
docs/telemetry-events.md | Documents new telemetry property for fallback URL usage |
Originally posted by @copilot-pull-request-reviewer in gitkraken/vscode-gitlens#4418 (review)
Metadata
Metadata
Assignees
Labels
No labels