Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetsEndpointAddressPropertyToSpecifiedValue.
This test has failed 44 times in the last 30 days, but the code is literally verifying that the constructor sets a public property!!!!????
This test failed two days ago:
“Error calling Test Cleanup method for test class Microsoft.ApplicationInsights.Channel.TransmissionTest+Constructor: System.Net.Http.HttpRequestException: Error while copying content to a stream. ---> System.IO.IOException: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. ---> System.Net.Sockets.SocketException: An existing connection was forcibly closed by the remote host”
This is suspicious because this test doesn’t invoke any network operations.
Taking a closer look, this test class inherits some base classes. Reading the comments these seem to only exist to support testing Async operations in .Net 3.5 !!!!
Soooo….. I’m going to remove some of these complicated test dependencies.
Changes