Refactor datetime handling in FileTranscriptStore to eliminate strings #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165
The File Logger was incorrectly converting datetimes to strings as part of dealing with activty processing. Removed the not-needed conversion (string to datetime) to cleanup the underlying code and tests.
The logged warnings looked like:
This fix is part of my ongoing effort to cleanup all the broken windows in our build and test system.