Consolidating OAuthFlow begin_flow calls into single getTokenOrSignInResource API call #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into users/robrandao/get-token-or-sign-in
…into users/robrandao/get-token-or-sign-in
…into users/robrandao/get-token-or-sign-in
cleemullins
requested changes
Oct 8, 2025
Collaborator
cleemullins
left a comment
cleemullins
left a comment
There was a problem hiding this comment.
Looks awesome. Minor nitpicks.
...es/microsoft-agents-activity/microsoft_agents/activity/token_or_sign_in_resource_response.py
Show resolved
Hide resolved
...es/microsoft-agents-activity/microsoft_agents/activity/token_or_sign_in_resource_response.py
Show resolved
Hide resolved
libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/_oauth/_oauth_flow.py
Outdated
Show resolved
Hide resolved
libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/_oauth/_oauth_flow.py
Show resolved
Hide resolved
...soft-agents-hosting-core/microsoft_agents/hosting/core/connector/client/user_token_client.py
Outdated
Show resolved
Hide resolved
...ies/microsoft-agents-hosting-core/microsoft_agents/hosting/core/connector/user_token_base.py
Show resolved
Hide resolved
...ies/microsoft-agents-hosting-core/microsoft_agents/hosting/core/connector/user_token_base.py
Show resolved
Hide resolved
….com/microsoft/Agents-for-python into users/robrandao/get-token-or-sign-in
cleemullins
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new unified method for obtaining either a user token or a sign-in resource in the OAuth flow, simplifying how authentication is handled and reducing redundant code paths. The changes span both the activity and hosting core libraries, with adjustments to models, API client interfaces, and the OAuth flow logic.
OAuth Flow Improvements:
TokenOrSignInResourceResponsemodel and related imports tomicrosoft_agents/activity/__init__.pyto support unified token/sign-in responses._oauth_flow.pyto use the new_get_token_or_sign_in_resourcemethod, streamlining the process of obtaining a user token or sign-in resource and removing the need for separate continuation activity handling. [1] [2] [3] [4]API Client Changes:
_get_token_or_sign_in_resourcemethod inuser_token_client.pyand updated imports to include the new response model, enabling the client to handle both token and sign-in resource retrieval in a single call. [1] [2]_get_token_or_sign_in_resourceinuser_token_base.pyto ensure all token client implementations support this unified interface.Model Additions:
TokenOrSignInResourcemodel to encapsulate bothTokenResponseandSignInResourcein a single response type, supporting the new unified authentication flow.