Handle null scopes in MsalAuth.cs more robustly #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the `scopes` parameter is checked for null before joining its elements into a string. This prevents potential null reference exceptions. Changes are applied when constructing the `cacheKey` and setting the "scope" parameter in the `parameters` dictionary.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds null safety checks for the scopes parameter in the GetAgenticUserTokenAsync method to prevent potential null reference exceptions. The changes ensure that null scopes are handled gracefully by using empty strings instead of attempting to join null collections.
Key changes:
- Added null checks before calling
string.Join()on the scopes parameter - Used empty strings as fallbacks when scopes is null
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tracyboehrer
previously approved these changes
Oct 10, 2025
Ensure that the `scopes` parameter is checked for null before joining its elements into a string. This prevents potential null reference exceptions. Changes are applied when constructing the `cacheKey` and setting the "scope" parameter in the `parameters` dictionary.
…crosoft/Agents-for-net into users/mbarbour/ValidateScopes
github-actions
bot
added
ML: Samples
github-actions
bot
removed
ML: Samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the
scopesparameter is checked for null before joining its elements into a string. This prevents potential null reference exceptions. Changes are applied when constructing thecacheKeyand setting the "scope" parameter in theparametersdictionary.