Skip to content

Conversation

@fpfp100
Copy link
Contributor

@fpfp100 fpfp100 commented Jan 8, 2026

Fix the issue that domain override has dependency on environment setting A365_OBSERVABILITY_USE_CUSTOM_DOMAIN

@fpfp100 fpfp100 requested a review from a team as a code owner January 8, 2026 01:40
Copilot AI review requested due to automatic review settings January 8, 2026 01:40
@fpfp100 fpfp100 changed the title fix the issue that domain override has dependency on setting A365_OBS… Fix the issue that domain override has dependency on setting A365_OBS… Jan 8, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an issue where the domain override functionality (A365_OBSERVABILITY_DOMAIN_OVERRIDE) was dependent on the A365_OBSERVABILITY_USE_CUSTOM_DOMAIN environment variable. The fix extracts domain override logic into a separate function and checks it independently before falling back to other endpoint resolution methods.

Key changes:

  • Extracted domain override logic into a new getAgent365ObservabilityDomainOverride() function
  • Modified endpoint resolution to check domain override first, independent of custom domain flag
  • Added test coverage for the scenario where domain override is set but custom domain flag is false

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
packages/agents-a365-observability/src/tracing/util.ts Refactored resolveAgent365Endpoint() to remove domain override logic and added new getAgent365ObservabilityDomainOverride() function to handle override independently
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts Updated endpoint resolution logic to check domain override first before using custom domain or discovery endpoints; renamed variable from endpointPath to endpointRelativePath for clarity
tests/observability/core/agent365-exporter.test.ts Added new test case for domain override with custom domain flag set to false; updated test description and added assertion to verify tenant-id header behavior

juliomenendez
juliomenendez previously approved these changes Jan 8, 2026
Copilot AI review requested due to automatic review settings January 8, 2026 19:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

@fpfp100 fpfp100 merged commit 37581cc into main Jan 8, 2026
13 checks passed
@fpfp100 fpfp100 deleted the users/pefan/overwrite2 branch January 8, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants