-
Notifications
You must be signed in to change notification settings - Fork 5
Fix the issue that domain override has dependency on setting A365_OBS… #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ERVABILITY_USE_CUSTOM_DOMAIN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes an issue where the domain override functionality (A365_OBSERVABILITY_DOMAIN_OVERRIDE) was dependent on the A365_OBSERVABILITY_USE_CUSTOM_DOMAIN environment variable. The fix extracts domain override logic into a separate function and checks it independently before falling back to other endpoint resolution methods.
Key changes:
- Extracted domain override logic into a new
getAgent365ObservabilityDomainOverride()function - Modified endpoint resolution to check domain override first, independent of custom domain flag
- Added test coverage for the scenario where domain override is set but custom domain flag is false
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
packages/agents-a365-observability/src/tracing/util.ts |
Refactored resolveAgent365Endpoint() to remove domain override logic and added new getAgent365ObservabilityDomainOverride() function to handle override independently |
packages/agents-a365-observability/src/tracing/exporter/Agent365Exporter.ts |
Updated endpoint resolution logic to check domain override first before using custom domain or discovery endpoints; renamed variable from endpointPath to endpointRelativePath for clarity |
tests/observability/core/agent365-exporter.test.ts |
Added new test case for domain override with custom domain flag set to false; updated test description and added assertion to verify tenant-id header behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Fix the issue that domain override has dependency on environment setting A365_OBSERVABILITY_USE_CUSTOM_DOMAIN