Skip to content

Conversation

@licanhua
Copy link
Contributor

@licanhua licanhua commented Dec 9, 2021

Fix #6656. which enabled JS test
Fix #6749. It's used to catch bugs like #6746.
Currently the js-ci pipeline failed because of #6843. It's expected.
note: all .ts files' change are not related to my PR and it's automatically formatted by huskey hook when I merged the branch with main

Because lerna workspace, webpack and npm pack, the actual package we released is a little different what we see in source/nodejs/adaptivecards*/. So even the build passed on our dev environment, we still don't have 100% confidence on our package.
This PR used npm pack to build the package we npm publish to npmjs website, and then the two apps consumes these packages.

Here is the logic.

  1. make a copy for the two test project: adaptivecards-react-testapp and adaptivecards-ui-testapp
  2. build the js projects as usual
  3. run npm pack to make packages for adaptivecards, adaptivecards-controls, adaptivecards-designer, adaptivecards-templating and adaptivecards-react
  4. install the .tgz package on the copied testapp, and rebuilt them.

Example of carousel failure(#6746) detected by this pipeline:
image
https://microsoft.visualstudio.com/AdaptiveCards/_build/results?buildId=42543322&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=35f53584-79fc-539f-463c-6471d0663a3a

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Dec 9, 2021

Hi @licanhua. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@licanhua
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jonmill jonmill marked this pull request as draft December 16, 2021 18:47
@ghost ghost added the no-recent-activity label Dec 22, 2021
@ghost
Copy link

ghost commented Dec 22, 2021

Hi @licanhua. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Staleness reset by licanhua

@licanhua licanhua marked this pull request as ready for review January 4, 2022 19:49
@ghost ghost removed the Needs: Author Feedback label Jan 11, 2022
@licanhua licanhua requested a review from paulcam206 January 11, 2022 22:47
@almedina-ms almedina-ms self-requested a review January 12, 2022 00:33
@licanhua licanhua merged commit 5f410a6 into main Jan 13, 2022
@licanhua licanhua deleted the canhua/js-ci branch January 13, 2022 01:07
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* redo pipeline

* update testapp

* Revert "update testapp"

This reverts commit 1018f96.

* update pipeline

* small change

* npm i -g npm@latest on Windows image

* npm i --force

* build and run test in /tests/ folder

* Update js-ci.yml for Azure Pipelines

* disabe ui test
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* redo pipeline

* update testapp

* Revert "update testapp"

This reverts commit 1018f96.

* update pipeline

* small change

* npm i -g npm@latest on Windows image

* npm i --force

* build and run test in /tests/ folder

* Update js-ci.yml for Azure Pipelines

* disabe ui test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JS] setup new pipeline to consume npm packages Add and Enable JS test on pipeline

4 participants