[JS] Modernize and automate code quality/formatting #6815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
paulcam206
force-pushed
the
paulcam/eslint-fixes
branch
from
64dd28b to
9706d08
Compare
licanhua
reviewed
Dec 7, 2021
source/nodejs/adaptivecards/src/__tests__/components/carousel.spec.ts
Outdated
Show resolved
Hide resolved
licanhua
reviewed
Dec 7, 2021
paulcam206
force-pushed
the
paulcam/eslint-fixes
branch
from
9706d08 to
3db9c20
Compare
jwoo-msft
approved these changes
Dec 8, 2021
run "npx lint-staged" from nodejs root for service
does not include fixing of fixes :)
paulcam206
force-pushed
the
paulcam/eslint-fixes
branch
from
9971adb to
79ff05d
Compare
licanhua
approved these changes
Dec 9, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [JS] `prettier` config and updated `eslint` Fixes microsoft#6757 * lint-staged config run "npx lint-staged" from nodejs root for service * set up husky * `eslint --fix` on `adaptivecards` does not include fixing of fixes :) * eslint manual cleanup * Fix formatting of properties with quotes * `prettier` format `adaptivecards` * tsx/jsx support and remove from .editorconfig * Pre-filter commit hook to only check if files opened in nodejs
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [JS] `prettier` config and updated `eslint` Fixes microsoft#6757 * lint-staged config run "npx lint-staged" from nodejs root for service * set up husky * `eslint --fix` on `adaptivecards` does not include fixing of fixes :) * eslint manual cleanup * Fix formatting of properties with quotes * `prettier` format `adaptivecards` * tsx/jsx support and remove from .editorconfig * Pre-filter commit hook to only check if files opened in nodejs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6657
Fixes #6757
Description
The commits on this PR are structured such that each is self-contained:
eslintprettiernpmscripts updated forlintlint-staged, a tool that can run sets of tools against changes staged ingithusky, a client-sidegithook managerhuskyup to our rootpreparelifecycle scripteslint --fixon theadaptivecardspackage - no manual editseslintissues. This is probably the most important thing to review!prettieron stuff inadaptivecards- no manual editsWith these changes, after this branch is merged, doing an
npm installinsource/nodejswill automatically installhusky-managedgithooks. After a file undersource/nodejsis modified and staged, attempting to commit it will causeeslintandprettierto run. Automatically-fixable issues detected byeslintwill be fixed and any formatting changes that need to be made will also be done automatically. Any errors fromeslintthat aren't auto-fixable will yield an error and refuse the commit. This hook can be bypassed using the--no-verifygitcommandline argument.I should note that I didn't apply any autofixing or formatting outside of the
adaptivecardspackage for now, as each individual package will need its own dedicated time.Microsoft Reviewers: Open in CodeFlow