[iOS] fixed empty filtered list issue #6528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
approved these changes
Oct 7, 2021
Contributor
|
Is it possible to add a test for this? |
licanhua
reviewed
Oct 8, 2021
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRChoiceSetCompactStyleView.mm
Show resolved
Hide resolved
licanhua
approved these changes
Oct 8, 2021
jwoo-msft
added a commit
that referenced
this pull request
Jan 6, 2022
* [iOS] fixed empty filtered list issue * [iOS] changed to function call Co-authored-by: Canhua Li <[email protected]>
paulcam206
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Added App extension to podspec (#6849) * app extension model added updated spec added podspec at root for testing\n revert it spec updated updated pod spec pod spec update moretesting [updated macro name] * updated podspec * [ios] Updated to final podspec version * update compiler flag * pod spec update * updated flag name * [iOS] fixed empty filtered list issue (#6528) * [iOS] fixed empty filtered list issue * [iOS] changed to function call Co-authored-by: Canhua Li <[email protected]> * moving resource bundle to core (#6853) Co-authored-by: Janus Balatbat <[email protected]> * Rounding off to 2 decimals (#6863) * [ios] updated round off logic (#6866) * [ios] updated round off logic * [ios] refactored the code * [ios] fixed project file * [ios] fixed log * [ios] spec updated * update test (#6864) * added heartbeat test ios build infrastructure (#6842) * [iOS] added yml version of ci updated path [ios] path update [iOS] variable updated [ios] added new test scheme * [iOS] added spec linting task added missing test file updated spect lint task added error handling added parallelism to jobs * added cert test added cert install yml updated pass Update ios-heartbeat.yml for Azure Pipelines added provisional file added script unimportant commit unimportant commit unimportant commit * added e-mail message simple update added e-mail message added e-mail message added e-mail message updated e-mail message updated e-mail message updated e-mail message * updated cron job * added false test Revert "added false test" This reverts commit ef302f0. * added false test added build task to cert task added build task to cert task added build task to cert task good cert bad prov added app push * parameterized template updated parameters updated params updated parameters updated to correct provisional file * updated trigger * updated e-mail address Co-authored-by: Canhua Li <[email protected]> Co-authored-by: janusbal <[email protected]> Co-authored-by: Janus Balatbat <[email protected]> Co-authored-by: shabripabba <[email protected]>
jwoo-msft
added a commit
that referenced
this pull request
Feb 17, 2022
* Added App extension to podspec (#6849) * app extension model added updated spec added podspec at root for testing\n revert it spec updated updated pod spec pod spec update moretesting [updated macro name] * updated podspec * [ios] Updated to final podspec version * update compiler flag * pod spec update * updated flag name * [iOS] fixed empty filtered list issue (#6528) * [iOS] fixed empty filtered list issue * [iOS] changed to function call Co-authored-by: Canhua Li <[email protected]> * moving resource bundle to core (#6853) Co-authored-by: Janus Balatbat <[email protected]> * Rounding off to 2 decimals (#6863) * [ios] updated round off logic (#6866) * [ios] updated round off logic * [ios] refactored the code * [ios] fixed project file * [ios] fixed log * [ios] spec updated * update test (#6864) * added heartbeat test ios build infrastructure (#6842) * [iOS] added yml version of ci updated path [ios] path update [iOS] variable updated [ios] added new test scheme * [iOS] added spec linting task added missing test file updated spect lint task added error handling added parallelism to jobs * added cert test added cert install yml updated pass Update ios-heartbeat.yml for Azure Pipelines added provisional file added script unimportant commit unimportant commit unimportant commit * added e-mail message simple update added e-mail message added e-mail message added e-mail message updated e-mail message updated e-mail message updated e-mail message * updated cron job * added false test Revert "added false test" This reverts commit ef302f0. * added false test added build task to cert task added build task to cert task added build task to cert task good cert bad prov added app push * parameterized template updated parameters updated params updated parameters updated to correct provisional file * updated trigger * updated e-mail address * Bug fixes: Textblock layout | Parsing warnings (#7041) * need to take accoutn for empty * works but need to find memory leak * testing against stackedit * removing unneeded line | allocating array * clean up * getting rid of str() use from strigstream * handling link destination with [ character and other tokens * removing cpp changes Co-authored-by: Janus Balatbat <[email protected]> * Bug fixes: Handling of link markdown (#6922) * need to take accoutn for empty * works but need to find memory leak * testing against stackedit * removing unneeded line | allocating array * clean up * getting rid of str() use from strigstream * handling link destination with [ character and other tokens * removing the ios changes * resolving comments * resolving comments * clan format Co-authored-by: Janus Balatbat <[email protected]> * updated android-ci yml to use latest macOs Co-authored-by: Canhua Li <[email protected]> Co-authored-by: janusbal <[email protected]> Co-authored-by: Janus Balatbat <[email protected]> Co-authored-by: shabripabba <[email protected]>
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [iOS] fixed empty filtered list issue * [iOS] changed to function call Co-authored-by: Canhua Li <[email protected]>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [iOS] fixed empty filtered list issue * [iOS] changed to function call Co-authored-by: Canhua Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #6515
Description
if the input field is empty or the placeholder is set, the expand button showed an empty list instead of showing the whole list. The input will show the correct list in such cases with the fix.
How Verified
Manually verified and ran a unit tests.
Microsoft Reviewers: Open in CodeFlow