[Designer] Fix the card structure order problem #6457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licanhua
changed the title
Contributor
Author
|
Click this link to verify the change |
paulcam206
approved these changes
Sep 30, 2021
Member
paulcam206
left a comment
paulcam206
left a comment
There was a problem hiding this comment.
a couple of minor nits - good find!
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Fix the card structure order problem * remove number from let Co-authored-by: Paul Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6375
In the code, action is insert to the begin the tree, so for any cards with action, the order are messed up.
After the code change, the action is moved to the end.
Before
After
I did the manual testing, and will like if I can write automation for this
Microsoft Reviewers: Open in CodeFlow