[JS] Allow adaptivecards-react to be used by react typescript project #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
licanhua
changed the title
paulcam206
approved these changes
Sep 28, 2021
jwoo-msft
approved these changes
Oct 1, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…microsoft#6405) * Demo the error * Fix the lib/src folder problem * update doc * files changed after build * Update source/nodejs/adaptivecards-react/README.md Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: Paul Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6398. It addressed:
import defaultHostConfigJson from '../assets/default-host-config.json'. the '../' forces the build output to lib/src, so typescript project can't import the module correctly. Move assets to src/assetsnpx lerna run buildMicrosoft Reviewers: Open in CodeFlow