-
Notifications
You must be signed in to change notification settings - Fork 176
Fix build error when using versioningStrategy 3+16 #2056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@microsoft-github-policy-service agree [company="Directions For Partners"] |
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes issue #2055 where using versioningStrategy 3+16 (value 19) caused AL-Go to generate an incorrect 5-digit version number (e.g., "1.2.3.-1.4") instead of a proper 4-digit version. The fix extracts Major.Minor from the repoVersion setting and handles the Build number separately for strategy 3.
Key changes:
- Fixed version number construction for versioningStrategy 3+16 to properly extract Major.Minor and Build components
- Added warning message when repoVersion lacks a Build number with strategy 3+16
- Updated release notes to document the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Actions/RunPipeline/RunPipeline.ps1 | Fixed versioning logic to parse repoVersion as System.Version object and extract Build number for strategy 3+16, preventing 5-digit version numbers |
| RELEASENOTES.md | Added entry documenting the fix for issue #2055 regarding versioningStrategy 3+16 build errors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Head branch was pushed to by a user without write access
Co-authored-by: Copilot <[email protected]>
❔What, Why & How
When using versioningStrategy 19 (16 + 3), AL-Go will wrongly create a version number with 5 digits during build: 1.2.3.-1.4
Related to issue: #2055
Fixes #2055
✅ Checklist