Skip to content

Conversation

@Freddy-D4P
Copy link
Contributor

@Freddy-D4P Freddy-D4P commented Dec 3, 2025

❔What, Why & How

When using versioningStrategy 19 (16 + 3), AL-Go will wrongly create a version number with 5 digits during build: 1.2.3.-1.4

Related to issue: #2055

Fixes #2055

✅ Checklist

  • Add tests (E2E, unit tests)
  • Update RELEASENOTES.md
  • Update documentation (e.g. for new settings or scenarios)
  • Add telemetry

@Freddy-D4P Freddy-D4P requested a review from a team as a code owner December 3, 2025 05:42
@Freddy-D4P
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="Directions For Partners"]

@Freddy-D4P
Copy link
Contributor Author

@microsoft-github-policy-service agree

mazhelez
mazhelez previously approved these changes Dec 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #2055 where using versioningStrategy 3+16 (value 19) caused AL-Go to generate an incorrect 5-digit version number (e.g., "1.2.3.-1.4") instead of a proper 4-digit version. The fix extracts Major.Minor from the repoVersion setting and handles the Build number separately for strategy 3.

Key changes:

  • Fixed version number construction for versioningStrategy 3+16 to properly extract Major.Minor and Build components
  • Added warning message when repoVersion lacks a Build number with strategy 3+16
  • Updated release notes to document the fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
Actions/RunPipeline/RunPipeline.ps1 Fixed versioning logic to parse repoVersion as System.Version object and extract Build number for strategy 3+16, preventing 5-digit version numbers
RELEASENOTES.md Added entry documenting the fix for issue #2055 regarding versioningStrategy 3+16 build errors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mazhelez
Copy link
Collaborator

mazhelez commented Dec 3, 2025

⚠️ Release Notes Update Reminder

Thank you for updating the release notes!

Please ensure that your changes are placed above the new version section (currently ## v8.1) in the RELEASENOTES.md file.

This helps maintain a clear changelog structure where new changes are grouped under the latest unreleased version.

@Freddy-D4P Freddy-D4P requested a review from mazhelez December 9, 2025 11:21
mazhelez
mazhelez previously approved these changes Dec 12, 2025
@mazhelez mazhelez enabled auto-merge (squash) December 12, 2025 11:01
@mazhelez mazhelez requested a review from Copilot December 12, 2025 11:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aholstrup1 aholstrup1 changed the title Fix for issue 2055 Fix build error when using versioningStrategy 3+16 Dec 12, 2025
aholstrup1
aholstrup1 previously approved these changes Dec 12, 2025
auto-merge was automatically disabled December 12, 2025 12:28

Head branch was pushed to by a user without write access

@Freddy-D4P Freddy-D4P dismissed stale reviews from aholstrup1 and mazhelez via 1a94ac9 December 12, 2025 12:28
@mazhelez mazhelez merged commit 4ef89d8 into microsoft:main Dec 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: When using versioningStrategy 3+16, you get an error when building

4 participants