-
Notifications
You must be signed in to change notification settings - Fork 176
Fix DateTime parsing fails on non-US locale runners #2047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mazhelez <[email protected]>
|
@copilot don't forget the release notes 😉 |
Co-authored-by: mazhelez <[email protected]>
Co-authored-by: mazhelez <[email protected]>
|
@copilot please fix the release notes. |
Co-authored-by: mazhelez <[email protected]>
... Fixed in commit 5702191. Moved the Issue 2045 entry to an unreleased section above the v8.1 version header. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: mazhelez <[email protected]>
…d of redefining Co-authored-by: mazhelez <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WorkflowInitialize.ps1(serialization) andWorkflowPostProcess.ps1(deserialization)WorkflowInitialize.ps1: Use ISO 8601 format (ToString("o")) for locale-agnostic serializationWorkflowPostProcess.ps1: Convert datetime to UTC before calculating durationConvertToUtcDateTimefunctionSummary
This PR fixes a bug where DateTime parsing fails on non-US locale runners (e.g., Australian locale) in WorkflowPostProcess.ps1.
Root Cause: The workflowStartTime was being serialized using the current culture's date format, but when deserialized on a machine with a different locale, the format didn't match, causing parsing failures.
Solution:
ToString("o")) which is locale-independentConvertToUtcDateTimefunction that ensures UTC conversion with InvariantCultureOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.