-
Notifications
You must be signed in to change notification settings - Fork 174
Give a warning before trying to publish symbols-only packages #1795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rup/symbolspackage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
❔What, Why & How
We've seen a couple of issues where builds are failing because one of the installApps is a symbols-only package. We could improve a bit here by displaying a warning when people try to do this. Eventually, this should probably be an error but showing a warning is a good first step IMO.
Related to issue: #1512
✅ Checklist