-
Notifications
You must be signed in to change notification settings - Fork 65
Description
Hi, I was hoping someone wouldn't mind helping me clarify a few problems I've encountered when working with the Metrics 5.1. TCK
Firstly, the adding of the microprofile-config.properties seems strange. In the Config API TCK, this file is added using this line:
.addAsWebInfResource(mpConfig, "classes/META-INF/microprofile-config.properties");
This adds the file to WEB-INF/classes/META-INF, which is on the application class path.
In the Metrics TCK however, this file is added using this line:
.addAsManifestResource("META-INF/microprofile-config-badHistogramTimerConfig.properties",
"microprofile-config.properties");
In the tests here: https://github.com/microprofile/microprofile-metrics/tree/main/tck/api/src/main/java/org/eclipse/microprofile/metrics/tck/config
This adds the file to META-INF, which isn't on the application class path (of a WAR archive), so the configuration isn't found.
According to microprofile/microprofile-config#268 and https://github.com/microprofile/microprofile-config#design it should be WEB-INF/classes/META-INF for a WAR archive, no?
Thanks in advance
Richard