define depency to opentelemetry-instrumentation-api-incubator #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see: micronaut-projects/micronaut-azure#857 `NewSpanOpenTelemetryTraceInterceptor` uses `io.opentelemetry.instrumentation.api.incubator.semconv.util.ClassAndMethod`.That class comes from: `io.opentelemetry.instrumentation:opentelemetry-instrumentation-api-incubator:2.16.0-alpha` It does not define a `@Requires` to that class. However, that dependency is resolved right now as a transitive dependency of the `opentelemetry-aws-sdk` compileOnly dependency: ``` +--- io.opentelemetry.instrumentation:opentelemetry-aws-sdk-2.2:2.16.0-alpha (c) | \--- io.opentelemetry.instrumentation:opentelemetry-instrumentation-api-incubator:2.16.0-alpha (c) ``` I see two solutions: A) We annotate `NewSpanOpenTelemetryTraceInterceptor` with `@Requires(we either define an `@Requires(ClassAndMethod.clasS)` B) We define the instrumentation.api.incubator dependency explicitly. This PR adds the dependency.
burtbeckwith
approved these changes
Jun 19, 2025
n0tl3ss
approved these changes
Jun 19, 2025
github-project-automation
bot
moved this from Ready for Review
to Done
in 4.9.0 Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: micronaut-projects/micronaut-azure#857
NewSpanOpenTelemetryTraceInterceptorusesio.opentelemetry.instrumentation.api.incubator.semconv.util.ClassAndMethod.That class comes from:io.opentelemetry.instrumentation:opentelemetry-instrumentation-api-incubator:2.16.0-alphaIt does not define a
@Requiresto that class.However, that dependency is resolved right now as a transitive dependency of the
opentelemetry-aws-sdkcompileOnly dependency:I see two solutions:
We annotate
NewSpanOpenTelemetryTraceInterceptorwith@Requires(ClassAndMethod.class)We define the instrumentation.api.incubator dependency explicitly.
This PR adds the dependency.