Missing `@Nullable` in bridge for brave Baggage implementation

[rgarciapariente]

Hello,

With version micrometer-tracing-bridge-brave:1.2.x you could do baggage.makeCurrent(null) to remove a baggage value but with micrometer-tracing-bridge-brave:1.3.x, all API are @NotNull by default.

Maybe, it is possible to add @Nullable to makeCurrent and set methods in class io.micrometer.tracing.brave.bridge.BraveBaggageInScope to avoid issues with nullabilities check?

Many thanks & regards

[shakuzen]

Thanks for the report. It looks like that was done in #545. Probably we should have been more careful to note which API should accept nullable values.

[shakuzen]

With #1120, I've added a bunch of nullability annotations and NullAway is happy with the state of things. There may still be some cases where the nullability isn't right. Could you check the latest 1.6.0-SNAPSHOT and let us know if this issue is fixed?

[rgarciapariente]

Hello,

I am using the IntelliJ problem report.

For baggage.makeCurrent(null); I continue see the warning Passing 'null' argument to parameter annotated as @NotNull with version 1.6.0-SNAPSHOT.

Thanks and regards

[shakuzen]

Thank you for taking a look. Indeed I didn't add Nullable there because Brave doesn't mark the argument on the method we call in that case as Nullable. Taking a look at the implementation, I'm not sure why it isn't marked nullable. It may be an oversight because it looks inconsistent. On the OTel side, I'd need to take a closer look. I've opened #1134 which I think captures the updates to nullability you are requesting. Let us know if there's any feedback.