Skip to content

Conversation

HeeChanN
Copy link
Contributor

Override MetricsDSLContext#fetchExists(Table, Condition) to delegate to
super.fetchExists(DSL.selectOne().from(table).where(condition)), forcing the
standard SELECT path so that JooqExecuteListener receives the tags and metrics
are reported with the provided tags.

Tests:

  • fetchExistsIsTimedWithProvidedTags: verifies that calling
    dsl.tag("name","checkAuthorExists").fetchExists(...) records "jooq.query"
    with tags name=checkAuthorExists and type=read, and timer count = 1 on H2.

related #6583

Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request with a fix and a test for the issue. I'll rebase it on the 1.14.x branch so we can easily include it in upcoming maintenance releases.

@shakuzen shakuzen changed the base branch from main to 1.14.x August 20, 2025 06:27
@shakuzen shakuzen enabled auto-merge (squash) August 20, 2025 06:39
@shakuzen shakuzen merged commit 38ec7c3 into micrometer-metrics:1.14.x Aug 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants