Add SmartKeyName API for consistent KeyValues with fallback support #6571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SmartKeyName class with required/optional/withFallback factory methods - Add KeyValues.of() and and() methods for SmartKeyName integration - Support automatic fallback handling to ensure consistent key sets - Add comprehensive test coverage for all SmartKeyName scenarios Fixes micrometer-metrics#6564 Signed-off-by: yybmion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
SmartKeyNameAPI to provide automatic fallback handling for KeyValues, ensuring consistent key sets across observations as required by Prometheus.SmartKeyName<C>class withrequired(),optional(), andwithFallback()factory methodsKeyValues.of()andKeyValues.and()methods to support SmartKeyName integrationCloses #6564