Bump io.prometheus:prometheus-metrics-bom from 1.3.1 to 1.3.3 #5649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [io.prometheus:prometheus-metrics-bom](https://github.com/prometheus/client_java) from 1.3.1 to 1.3.3. - [Release notes](https://github.com/prometheus/client_java/releases) - [Commits](prometheus/client_java@v1.3.1...v1.3.3) --- updated-dependencies: - dependency-name: io.prometheus:prometheus-metrics-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependency-upgrade
|
The build is failing because the Prometheus Java Client used to let users to use colons ( See the docs: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
So even if metric names can contain colons ( See |
jonatan-ivanov
force-pushed
the
dependabot/gradle/main/io.prometheus-prometheus-metrics-bom-1.3.3
branch
from
0fdc4c0 to
5b5bdf0
Compare
The Prometheus Java Client used to let users to use colons (":")
in the metric names. Apparently, this should have not been allowed.
See the docs: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
"Metric names may contain ASCII letters, digits, underscores,
and colons. It must match the regex [a-zA-Z_:][a-zA-Z0-9_:]*.
Note: The colons are reserved for user defined recording rules.
They should not be used by exporters or direct instrumentation."
So even if metric names can contain colons (":"),
exporters (like the Prometheus Java Client or Micrometer)
should not use it. The Prometheus Java Client replaces colons (":")
to underscores ("_") starting from 1.3.3.
See prometheus/client_java#974
See prometheus/client_java#975
See #5649
jonatan-ivanov
force-pushed
the
dependabot/gradle/main/io.prometheus-prometheus-metrics-bom-1.3.3
branch
from
5b5bdf0 to
ca0750e
Compare
jonatan-ivanov
deleted the
dependabot/gradle/main/io.prometheus-prometheus-metrics-bom-1.3.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps io.prometheus:prometheus-metrics-bom from 1.3.1 to 1.3.3.
Release notes
Sourced from io.prometheus:prometheus-metrics-bom's releases.
Commits
2c022becreate release (#1194)da91960revert incompatible api change (#1192)7bc442favoid ConcurrentModificationException (#1191)76cb93eUpdate RELEASING.md (#1188)fc583c2improve release (#1187)05c6862Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.10.1 to 3.11.1 (#1185)036570fBump org.apache.maven.plugins:maven-failsafe-plugin from 3.5.1 to 3.5.2 (#1184)048cbd5Bump org.apache.maven.plugins:maven-surefire-plugin from 3.5.1 to 3.5.2 (#1183)1b4d99dBump org.codehaus.mojo:exec-maven-plugin from 3.4.1 to 3.5.0 (#1181)5c81cc1Bump io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)