Skip to content

Warn about Prometheus meter registration failure #5228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Warn about Prometheus meter registration failure #5228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ...try-prometheus/src/main/java/io/micrometer/prometheusmetrics/PrometheusMeterRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package io.micrometer.prometheusmetrics;

import io.micrometer.common.lang.Nullable;
import io.micrometer.common.util.internal.logging.WarnThenDebugLogger;
import io.micrometer.core.instrument.*;
import io.micrometer.core.instrument.cumulative.CumulativeFunctionCounter;
import io.micrometer.core.instrument.cumulative.CumulativeFunctionTimer;
Expand Down Expand Up @@ -68,6 +69,8 @@
*/
public class PrometheusMeterRegistry extends MeterRegistry {

private static final WarnThenDebugLogger log = new WarnThenDebugLogger(PrometheusMeterRegistry.class);

private final PrometheusConfig prometheusConfig;

private final PrometheusRegistry registry;
Expand Down Expand Up @@ -611,6 +614,24 @@ public PrometheusMeterRegistry throwExceptionOnRegistrationFailure() {
return this;
}

@Override
protected void meterRegistrationFailed(Meter.Id id, String reason) {
super.meterRegistrationFailed(id, reason);

log.log(() -> createMeterRegistrationFailureMessage(id, reason));
}

private static String createMeterRegistrationFailureMessage(Meter.Id id, String reason) {
String message = String.format("The meter (%s) registration has failed", id);
if (reason != null) {
message += ": " + reason;
}
else {
message += ".";
}
return message;
}

private enum Format {

TEXT_004("text/plain; version=0.0.4; charset=utf-8");
Expand Down