Verify sender propagation for HTTP server instrumentation #3507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will catch issues in the implementation of instrumentation. For example, if the carrier is set after an Observation is started, this new test will not pass.
shakuzen
added
type: task
shakuzen
commented
Oct 28, 2022
| @@ -36,7 +36,7 @@ public class JerseyContext extends RequestReplyReceiverContext<ContainerRequest, | |||
| public JerseyContext(RequestEvent requestEvent) { | |||
| super((carrier, key) -> { | |||
| List<String> requestHeader = carrier.getRequestHeader(key); | |||
| if (requestHeader.isEmpty()) { | |||
| if (requestHeader == null || requestHeader.isEmpty()) { | |||
There was a problem hiding this comment.
A NPE was being thrown when trying to use the Getter on a key that wasn't in the headers. The above getRequestHeader returns null for an absent key.
marcingrzejszczak
approved these changes
Oct 28, 2022
|
|
jonatan-ivanov
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will catch issues in the implementation of instrumentation. For example, if the carrier is set after an Observation is started, this new test will not pass.
Server equivalent of #3504